Fix the scanner to accept precerts

Fix the scanner to accept precerts

[ekasper, 2013-11-21 13:27:16]

- Partially parse precert entries. Currently just passes the original
precertificate - rather than the TBS + issuer key hash, or anything else - to
the matcher.

- Fix a multiprocessing bug where STOP_WORKER messages were sometimes arriving
out-of-order.

[ekasper, 2013-11-25 11:48:21]

Al, Eran - maybe you have time to pick this up while Ben is travelling?

On 2013/11/21 13:27:16, ekasper wrote:
> - Partially parse precert entries. Currently just passes the original
> precertificate - rather than the TBS + issuer key hash, or anything else - to
> the matcher.
> 
> - Fix a multiprocessing bug where STOP_WORKER messages were sometimes arriving
> out-of-order.

[Eran, 2013-11-25 11:51:11]

On 2013/11/25 11:48:21, ekasper wrote:
> Al, Eran - maybe you have time to pick this up while Ben is travelling?
> 
> On 2013/11/21 13:27:16, ekasper wrote:
> > - Partially parse precert entries. Currently just passes the original
> > precertificate - rather than the TBS + issuer key hash, or anything else -
to
> > the matcher.
> > 
> > - Fix a multiprocessing bug where STOP_WORKER messages were sometimes
arriving
> > out-of-order.

Yes, I can have a look later today.

[Eran, 2013-11-25 22:23:24]

LGTM, see comments below.

https://codereview.appspot.com/30290043/diff/20001/src/python/ct/client/tools...
File src/python/ct/client/tools/scan.py (right):

https://codereview.appspot.com/30290043/diff/20001/src/python/ct/client/tools...
src/python/ct/client/tools/scan.py:78: extensions_length_prefix =
leaf_bytes.read(2)
Nit: Extract extension reading to a separate method, this one is long enough.

https://codereview.appspot.com/30290043/diff/20001/src/python/ct/client/tools...
src/python/ct/client/tools/scan.py:85: raise Error("Input too short")
Distinct this error from the previous error, bonus points if you explicitly
state which field was too short.

https://codereview.appspot.com/30290043/diff/20001/src/python/ct/client/tools...
src/python/ct/client/tools/scan.py:90: else:
Nit: Explicitly check the type (or simply assert)

[ekasper, 2013-11-28 13:15:14]

https://codereview.appspot.com/30290043/diff/20001/src/python/ct/client/tools...
File src/python/ct/client/tools/scan.py (right):

https://codereview.appspot.com/30290043/diff/20001/src/python/ct/client/tools...
src/python/ct/client/tools/scan.py:78: extensions_length_prefix =
leaf_bytes.read(2)
On 2013/11/25 22:23:25, Eran wrote:
> Nit: Extract extension reading to a separate method, this one is long enough.

Done.

https://codereview.appspot.com/30290043/diff/20001/src/python/ct/client/tools...
src/python/ct/client/tools/scan.py:85: raise Error("Input too short")
On 2013/11/25 22:23:25, Eran wrote:
> Distinct this error from the previous error, bonus points if you explicitly
> state which field was too short.

Done.

https://codereview.appspot.com/30290043/diff/20001/src/python/ct/client/tools...
src/python/ct/client/tools/scan.py:90: else:
On 2013/11/25 22:23:25, Eran wrote:
> Nit: Explicitly check the type (or simply assert)

It's checked above.