Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1568)

Issue 302700043: ui/gtk3: support scroll event in candidates panel (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by Peng Wu
Modified:
6 years, 2 months ago
Reviewers:
shawn.p.huang, fujiwara, Peng, maiku.fabian
Visibility:
Public.

Description

ui/gtk3: support scroll event in candidates panel When press scroll button of mouse on candidates, automatically cursor up/cursor down. BUG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : ui/gtk3: support scroll event in candidates panel #

Total comments: 8

Patch Set 3 : ui/gtk3: support scroll event in candidates panel #

Patch Set 4 : ui/gtk3: support scroll event in candidates panel #

Patch Set 5 : ui/gtk3: support scroll event in candidates panel #

Total comments: 1

Patch Set 6 : ui/gtk3: support scroll event in candidates panel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M ui/gtk3/candidatearea.vala View 1 2 3 4 5 5 chunks +29 lines, -4 lines 0 comments Download
M ui/gtk3/panel.vala View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20
maiku.fabian
I tested Peng Wu’s patch on Fedora 24 and it works for me.
7 years, 6 months ago (2016-09-14 08:53:12 UTC) #1
fujiwara
I think scroll up/down is cursor up/down but not page up/down?
7 years, 6 months ago (2016-09-14 09:25:07 UTC) #2
maiku.fabian
Yes, cursor up/down would be nicer than page up/down.
7 years, 6 months ago (2016-09-14 09:27:55 UTC) #3
maiku.fabian
On 2016/09/14 09:27:55, maiku.fabian wrote: > Yes, cursor up/down would be nicer than page up/down. ...
7 years, 6 months ago (2016-09-14 09:32:29 UTC) #4
fujiwara
https://codereview.appspot.com/302700043/diff/1/ui/gtk3/candidatepanel.vala File ui/gtk3/candidatepanel.vala (right): https://codereview.appspot.com/302700043/diff/1/ui/gtk3/candidatepanel.vala#newcode266 ui/gtk3/candidatepanel.vala:266: page_up(); I think scroll up/down is cursor up/down but ...
7 years, 6 months ago (2016-09-14 09:34:32 UTC) #5
maiku.fabian
I tested the patch after changing page_up()/page_down() to cursor_up()/cursor_down(). Like this: diff --git a/ui/gtk3/candidatepanel.vala b/ui/gtk3/candidatepanel.vala ...
7 years, 6 months ago (2016-09-15 06:30:59 UTC) #6
fujiwara
On 2016/09/15 06:30:59, maiku.fabian wrote: > I tested the patch after changing page_up()/page_down() to > ...
7 years, 6 months ago (2016-09-15 07:31:09 UTC) #7
Peng Wu
Okay, updated the patch to use cursor up/cursor down now.
7 years, 6 months ago (2016-09-18 08:54:48 UTC) #8
maiku.fabian
On 2016/09/18 08:54:48, Peng Wu wrote: > Okay, updated the patch to use cursor up/cursor ...
7 years, 6 months ago (2016-09-18 10:38:15 UTC) #9
Peng
https://codereview.appspot.com/302700043/diff/20001/ui/gtk3/candidatearea.vala File ui/gtk3/candidatearea.vala (right): https://codereview.appspot.com/302700043/diff/20001/ui/gtk3/candidatearea.vala#newcode54 ui/gtk3/candidatearea.vala:54: public signal void scroll_clicked(Gdk.ScrollDirection direction); changed to candidate_scrolled? https://codereview.appspot.com/302700043/diff/20001/ui/gtk3/candidatearea.vala#newcode224 ...
7 years, 6 months ago (2016-09-23 13:33:36 UTC) #10
Peng Wu
https://codereview.appspot.com/302700043/diff/20001/ui/gtk3/candidatearea.vala File ui/gtk3/candidatearea.vala (right): https://codereview.appspot.com/302700043/diff/20001/ui/gtk3/candidatearea.vala#newcode54 ui/gtk3/candidatearea.vala:54: public signal void scroll_clicked(Gdk.ScrollDirection direction); On 2016/09/23 13:33:36, Peng ...
7 years, 6 months ago (2016-09-26 08:20:34 UTC) #11
Peng
https://codereview.appspot.com/302700043/diff/20001/ui/gtk3/candidatearea.vala File ui/gtk3/candidatearea.vala (right): https://codereview.appspot.com/302700043/diff/20001/ui/gtk3/candidatearea.vala#newcode224 ui/gtk3/candidatearea.vala:224: label_ebox.scroll_event.connect((w, e) => { On 2016/09/26 08:20:33, Peng Wu ...
7 years, 6 months ago (2016-09-26 23:59:35 UTC) #12
Peng
7 years, 6 months ago (2016-09-26 23:59:36 UTC) #13
Peng
7 years, 6 months ago (2016-09-26 23:59:38 UTC) #14
Peng Wu
I mean the label and candidates widgets on top of the container.
7 years, 6 months ago (2016-09-27 08:20:47 UTC) #15
Peng
On 2016/09/27 08:20:47, Peng Wu wrote: > I mean the label and candidates widgets on ...
7 years, 6 months ago (2016-09-27 14:38:45 UTC) #16
Peng Wu
On 2016/09/27 14:38:45, Peng wrote: > So can we ignore scroll events for label and ...
7 years, 5 months ago (2016-10-10 06:51:16 UTC) #17
fujiwara
lgtm https://codereview.appspot.com/302700043/diff/100001/ui/gtk3/candidatearea.vala File ui/gtk3/candidatearea.vala (right): https://codereview.appspot.com/302700043/diff/100001/ui/gtk3/candidatearea.vala#newcode242 ui/gtk3/candidatearea.vala:242: This line is no need.
7 years, 5 months ago (2016-10-11 05:30:10 UTC) #18
Peng
On 2016/10/11 05:30:10, fujiwara wrote: > lgtm > > https://codereview.appspot.com/302700043/diff/100001/ui/gtk3/candidatearea.vala > File ui/gtk3/candidatearea.vala (right): > ...
7 years, 5 months ago (2016-10-11 09:34:10 UTC) #19
Peng Wu
7 years, 5 months ago (2016-10-12 05:32:02 UTC) #20
Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b