Display bundle download counts in the UI.

Display bundle download counts in the UI.

- Update the model to carry the attribute from the api.
- Update the token to display the "Deployed X times".
- Update the details to also display the count.
- Drive-by to update the attributes in the charm model.
- Update tests with updated api download from the server that includes the
download counts. Required updating tests to the new data.

https://code.launchpad.net/~rharding/juju-gui/bundle-counts/+merge/196135

(do not edit description out of merge proposal)

[rharding, 2013-11-21 15:12:47]

Please take a look.

[rharding, 2013-11-21 18:10:32]

Please take a look.

[rharding, 2013-11-21 18:13:41]

Reviewer comments

https://codereview.appspot.com/30210044/diff/20001/app/models/bundle.js
File app/models/bundle.js (right):

https://codereview.appspot.com/30210044/diff/20001/app/models/bundle.js#newco...
app/models/bundle.js:57: this.set('recent_download_count',
cfg.downloads_in_past_30_days);
the api is downloads_in_past_30_days but we've moved that before from 90 and
such. So we map it to a more generic "recent" attr.

https://codereview.appspot.com/30210044/diff/20001/app/models/charm.js
File app/models/charm.js (right):

https://codereview.appspot.com/30210044/diff/20001/app/models/charm.js#newcod...
app/models/charm.js:476: downloads: {
drive-by, not sure how this attr was missing from before.

https://codereview.appspot.com/30210044/diff/20001/app/templates/bundle-token...
File app/templates/bundle-token.handlebars (right):

https://codereview.appspot.com/30210044/diff/20001/app/templates/bundle-token...
app/templates/bundle-token.handlebars:26: <div>Deployed {{downloads}}
{{pluralize 'time' downloads}}</div>
per UX, make the first item in the metadata list.

https://codereview.appspot.com/30210044/diff/20001/test/data/browserbundle.json
File test/data/browserbundle.json (right):

https://codereview.appspot.com/30210044/diff/20001/test/data/browserbundle.js...
test/data/browserbundle.json:1: {
IGNORE ME: Updated test file due to api changes. It's a mechanical change of
downloading new api result.

https://codereview.appspot.com/30210044/diff/20001/test/test_model_bundle.js
File test/test_model_bundle.js (right):

https://codereview.appspot.com/30210044/diff/20001/test/test_model_bundle.js#...
test/test_model_bundle.js:184: assert.lengthOf(commits, 5);
the rest of these are making the old tests match the updated api response.

https://codereview.appspot.com/30210044/diff/20001/test/test_model_bundle.js#...
test/test_model_bundle.js:195: // Manually added a second author into the test
data from the server.
this was manually tweaked in that api response so noted it here for future test
failures.

[jeff.pihach, 2013-11-21 18:56:37]

LGTM Thanks for adding this to the UI.

Using a valueFn here looks to be an unnecessary performance hit.

https://codereview.appspot.com/30210044/diff/20001/app/models/bundle.js
File app/models/bundle.js (right):

https://codereview.appspot.com/30210044/diff/20001/app/models/bundle.js#newco...
app/models/bundle.js:159: valueFn: function() {
Why can't you just set the initial value to 0 vs a valueFn?

https://codereview.appspot.com/30210044/diff/20001/app/models/bundle.js#newco...
app/models/bundle.js:177: valueFn: function() {
Same as above

https://codereview.appspot.com/30210044/diff/20001/app/models/charm.js
File app/models/charm.js (right):

https://codereview.appspot.com/30210044/diff/20001/app/models/charm.js#newcod...
app/models/charm.js:482: valueFn: function() {
same as in the bundle.js

[rharding, 2013-11-21 19:14:52]

*** Submitted:

Display bundle download counts in the UI.

- Update the model to carry the attribute from the api.
- Update the token to display the "Deployed X times".
- Update the details to also display the count.
- Drive-by to update the attributes in the charm model.
- Update tests with updated api download from the server that includes the
download counts. Required updating tests to the new data.

R=jeff.pihach
CC=
https://codereview.appspot.com/30210044