Issue 302060043: i#1569 AArch64: Replace "AARCH64 || ARM" with AARCHXX in many places.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 302060043: i#1569 AArch64: Replace "AARCH64 || ARM" with AARCHXX in many places. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by Edmund.Grimley.Evans

Modified:
10 years, 3 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1569 AArch64: Replace "AARCH64 || ARM" with AARCHXX in many places. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -104 lines)			Patch
M	core/arch/arch.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	core/arch/arch.c	View		9 chunks	+9 lines, -9 lines	0 comments	Download
M	core/arch/arch_exports.h	View		7 chunks	+8 lines, -8 lines	0 comments	Download
M	core/arch/asm_defines.asm	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	core/arch/decode.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	core/arch/emit_utils_shared.c	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	core/arch/instr.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/arch/instr_inline.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	core/arch/instr_shared.c	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	core/arch/interp.c	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	core/arch/mangle_shared.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	core/arch/opnd.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	core/arch/opnd_shared.c	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	core/lib/globals_shared.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	core/lib/instrument.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	core/lib/mcxtx.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	core/optionsx.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	core/os_shared.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	core/unix/injector.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	core/unix/loader_linux.c	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	core/unix/native_elf.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	core/unix/os.c	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	core/unix/os_exports.h	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	core/unix/os_private.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	core/unix/signal.c	View		10 chunks	+10 lines, -10 lines	0 comments	Download
M	core/unix/signal_private.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	core/unix/tls.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	core/unix/tls_linux_aarchxx.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ext/drreg/drreg.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ext/drutil/drutil.c	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ext/drwrap/drwrap.c	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ext/drx/drx.c	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	suite/tests/security-common/ret_noncall_trace.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	suite/tests/tools.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Edmund.Grimley.Evans

10 years, 3 months ago (2016-06-28 08:41:55 UTC) #3

Committed as
https://github.com/DynamoRIO/dynamorio/commit/e74114f638b35c401b1a2b271737646...

Final commit log: 
---------------
i#1569 AArch64: Replace "AARCH64 || ARM" with AARCHXX in many places.

Review-URL: https://codereview.appspot.com/302060043
---------------

Expand All Messages | Collapse All Messages