Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(464)

Issue 301980043: Reorganize listener/acknowledger initialization (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by dak
Modified:
1 month ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Reorganize listener/acknowledger initialization This reverts most of the changes of issue 4885 in order to arrive at listeners/acknowledgers that can be kept private or protected according to the actual use cases in engravers and other translators. It also streamlines some of the other code. Contains the following commits in reverse order (all separately tested to compile): Remove {Translator,Engraver}::ack_find_base The indirection and complication added by it does not really help in any manner. Remove Translator::method-find_base It's basically a trivial replacement and confuses more than it helps. Listeners should not be virtual Gregorian_ligature_engraver::listen_pes_or_flexa and Ligature_engraver::listen_pes_or_flexa were accidentally declared virtual, but their registration already caters for what amounts to virtual overrides in effect. Revert "Issue 4885/2: Let ADD_ACKNOWLEDGER state actual classes" This reverts commit 7c36dbb1834c7c68e4b94777241de3ea02971aca. Revert "Issue 4885/3: Remove ack_finder/ack_find_base" This reverts commit b9040afd1dcfbee6b45bc3d54850ff50d51c8ee9. Let method_finder also find listeners This allows using inherited listeners directly like with acknowledgers and translator methods.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -68 lines) Patch
M lily/auto-beam-engraver.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M lily/beam-engraver.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M lily/include/gregorian-ligature-engraver.hh View 2 chunks +1 line, -1 line 0 comments Download
M lily/include/ligature-engraver.hh View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/include/slur-proto-engraver.hh View 2 chunks +14 lines, -13 lines 0 comments Download
M lily/include/translator.hh View 2 chunks +23 lines, -6 lines 0 comments Download
M lily/include/translator.icc View 2 chunks +5 lines, -6 lines 0 comments Download
M lily/kievan-ligature-engraver.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M lily/mensural-ligature-engraver.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M lily/phrasing-slur-engraver.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M lily/slur-engraver.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M lily/vaticana-ligature-engraver.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b