Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(370)

Issue 301810043: Fix ses.funcLike protection against non-identifier names. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by kpreid_google
Modified:
6 years, 2 months ago
Reviewers:
MarkM
CC:
google-caja-discuss_googlegroups.com
Visibility:
Public.

Description

Any non-identifier or possible non-identifier will now be correctly rejected. Additionally, if the name merely contains a space (as in (function f() {}).bind().name === "bound f"), replace it with an underscore to make it valid. Fixes https://github.com/google/caja/issues/2001. @ 9f33b649ae8c2e8c068e1f03753ee275ccc0981d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M src/com/google/caja/ses/repairES5.js View 2 chunks +6 lines, -1 line 0 comments Download
M tests/com/google/caja/ses/test-ses-parts.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2
kpreid_google
6 years, 2 months ago (2016-05-27 22:00:21 UTC) #1
MarkM
6 years, 2 months ago (2016-05-27 23:01:50 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b