Issue 301090043: i#1569 AArch64: Disable sign_extend_immed on AArch64.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 301090043: i#1569 AArch64: Disable sign_extend_immed on AArch64. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 10 months ago by Edmund.Grimley.Evans

Modified:
7 years, 9 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1569 AArch64: Disable sign_extend_immed on AArch64. The automatic sign extension is probably only useful on Intel but is left enabled on ARM (AArch32) so as not to change the output from tests (api.disA32, api.disT32, api.static). This only affects disassembly. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	core/arch/disassemble_shared.c	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Edmund.Grimley.Evans

7 years, 9 months ago (2016-07-04 08:39:38 UTC) #3

Committed as
https://github.com/DynamoRIO/dynamorio/commit/ecdd2f753b4ae3a0c721e49eae890f8...

Final commit log: 
---------------
i#1569 AArch64: Disable sign_extend_immed on AArch64.

The automatic sign extension is probably only useful on Intel but
is left enabled on ARM (AArch32) so as not to change the output
from tests (api.disA32, api.disT32, api.static).

This only affects disassembly.

Review-URL: https://codereview.appspot.com/301090043
---------------

Expand All Messages | Collapse All Messages