Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7165)

Issue 300920043: i#1945 CF swapped: Fix DR_PRED_B/DR_PRED_NB comments

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by rocallahan
Modified:
7 years, 10 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1945 CF swapped: Fix DR_PRED_B/DR_PRED_NB comments Comment-only change. Fixes #1945 ---------------

Patch Set 1 #

Patch Set 2 : Addressed reviewer concerns #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M core/arch/instr.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
rocallahan
7 years, 10 months ago (2016-06-08 21:35:05 UTC) #1
bruening
Thanks for the fix. LGTM though with s/Comment/Documentation/ in the commit message.
7 years, 10 months ago (2016-06-12 20:17:18 UTC) #2
rocallahan
Commit log for latest patchset: --------------- i#1945 CF swapped: Fix DR_PRED_B/DR_PRED_NB comments Documentation-only change. Fixes ...
7 years, 10 months ago (2016-06-12 21:11:59 UTC) #3
rocallahan
7 years, 10 months ago (2016-06-12 21:12:37 UTC) #4
Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b