Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(95)

Issue 300850043: Added non-default property to KeySignature grob

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by panteck
Modified:
3 years, 3 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Added non-default property to KeySignature grob Added the non-default property to the KeySignature grob. It works exactly like the non-default property for Clef - if the Key Signature was created manually, it is set to true, otherwise it is unset. Also updated the grob properties for non-default to indicate that it works for both Clef and KeySignature grobs now.

Patch Set 1 #

Patch Set 2 : Added non-default to the key signature interface to remove warnings from the regtests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M lily/key-engraver.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M lily/key-signature-interface.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
panteck
Added non-default to the key signature interface to remove warnings from the regtests
3 years, 3 months ago (2016-06-01 02:43:13 UTC) #1
pkx166h
Patch counted down - please push. Steven if you do not have push access then ...
3 years, 3 months ago (2016-06-11 09:48:01 UTC) #2
pkx166h
3 years, 3 months ago (2016-06-12 08:54:07 UTC) #3
author	Steven Weber <panteck@hotmail.com>	
	Fri, 27 May 2016 22:41:43 +0100 (14:41 -0700)
committer	James Lowe <pkx166h@gmail.com>	
	Sun, 12 Jun 2016 09:52:45 +0100 (09:52 +0100)
commit	05ddf3b60d68b70afce5ff79992e725267bdca46
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b