Issue 300540043: i#1569 AArch64: Add dis-a64 pre-commit test.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 300540043: i#1569 AArch64: Add dis-a64 pre-commit test. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 10 months ago by Edmund.Grimley.Evans

Modified:
7 years, 10 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1569 AArch64: Add dis-a64 pre-commit test. In dis-a64.txt there is a list of encodings and corresponding disassemblies. This is checked by dis-a64.c, while dis-a64.pl is a script to facilitate generating dis-a64.txt. ---------------

Patch Set 1 #

Patch Set 2 : "dis-a64" replaces "dis" #

Total comments: 5

Patch Set 3 : Committed #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+488 lines, -3 lines)			Patch
M	core/arch/aarch64/decode.c	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	suite/tests/CMakeLists.txt	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
A	suite/tests/api/dis-a64.c	View	1 2	1 chunk	+221 lines, -0 lines	0 comments	Download
A	suite/tests/api/dis-a64.expect	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	suite/tests/api/dis-a64.pl	View		1 chunk	+121 lines, -0 lines	0 comments	Download
A	suite/tests/api/dis-a64.txt	View		1 chunk	+138 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Edmund.Grimley.Evans

Commit log for latest patchset: --------------- i#1569 AArch64: Add dis-a64 pre-commit test. In dis-a64.txt there ...

7 years, 10 months ago (2016-07-06 12:20:06 UTC) #2

zhaoqin

some nits LGTM https://codereview.appspot.com/300540043/diff/20001/suite/tests/CMakeLists.txt File suite/tests/CMakeLists.txt (right): https://codereview.appspot.com/300540043/diff/20001/suite/tests/CMakeLists.txt#newcode2 suite/tests/CMakeLists.txt:2: # Copyright (c) 2010-2016 Google, Inc. ...

7 years, 10 months ago (2016-07-07 21:56:14 UTC) #3

Edmund.Grimley.Evans

7 years, 10 months ago (2016-07-08 08:24:46 UTC) #4

Committed as
https://github.com/DynamoRIO/dynamorio/commit/3e3bba6084729456a00791e6a776f9d...

Final commit log: 
---------------
i#1569 AArch64: Add dis-a64 pre-commit test.

In dis-a64.txt there is a list of encodings and corresponding disassemblies.
This is checked by dis-a64.c, while dis-a64.pl is a script to facilitate
generating dis-a64.txt.

Review-URL: https://codereview.appspot.com/300540043
---------------

Expand All Messages | Collapse All Messages