Issue 29960045: Send bundle id when d'n'd from sidebar.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29960045: Send bundle id when d'n'd from sidebar.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by bac

Modified:
10 years, 5 months ago

Reviewers:
benji, mp+196139

Visibility:
Public.

Description

Send bundle id when d'n'd from sidebar. This path was initially missed. The Token had to be fixed to include the ID in the drag data. Note, for selfish reasons, test/utils.js loadFixtures was updated to retry on failures. The reason for the occassional 404 in this function when run by lbox is still unknown. Hopefully the dumb retry will help. QA Instructions: # Use juju-quickstart trunk % cd projects/juju-quickstart % bzr pull % make # Deploy on EC2 % juju switch ec2 % .venv/bin/python juju-quickstart --gui-charm-url cs:~juju-gui/precise/juju-gui-128 % juju set juju-gui "juju-gui-source=lp:~bac/juju-gui/fix-dnd-bundles-wrt-id" # May want to wait a bit. Perhaps it isn't necessary. % juju set juju-gui "charmworld-url=http://staging.jujucharms.com" Find one of Jorge's bundles on http://staging.jujucharms.com. (wordpress-simple is a fast one.) Look at the deployment counts. In the GUI search for 'jorge', find the bundle from above, and *drag* it onto the canvas. Have a light snack. When everything is green and happy, look at the page again on staging and see that the count has increased by one. NOTE: in my QA I didn't see the incremented values reflected immediately which is really strange. A few minutes later they were updated. https://code.launchpad.net/~bac/juju-gui/fix-dnd-bundles-wrt-id/+merge/196139 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Send bundle id when d'n'd from sidebar. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -8 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/topology/service.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	app/widgets/token.js	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	test/test_service_module.js	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	test/utils.js	View	1 chunk	+15 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bac

10 years, 5 months ago (2013-11-21 17:24:24 UTC) #3

*** Submitted:

Send bundle id when d'n'd from sidebar.

This path was initially missed.  The Token had to be fixed to include the
ID in the drag data.

Note, for selfish reasons, test/utils.js loadFixtures was updated to retry on
failures.  The reason for the occassional 404 in this function when run by
lbox is still unknown.  Hopefully the dumb retry will help.

QA Instructions:

# Use juju-quickstart trunk
% cd projects/juju-quickstart
% bzr pull
% make
# Deploy on EC2
% juju switch ec2
% .venv/bin/python juju-quickstart --gui-charm-url
cs:~juju-gui/precise/juju-gui-128
% juju set juju-gui "juju-gui-source=lp:~bac/juju-gui/fix-dnd-bundles-wrt-id"
# May want to wait a bit.  Perhaps it isn't necessary.
% juju set juju-gui "charmworld-url=http://staging.jujucharms.com"

Find one of Jorge's bundles on http://staging.jujucharms.com.
(wordpress-simple is a fast one.)  Look at the deployment counts.

In the GUI search for 'jorge', find the bundle from above, and *drag* it onto
the canvas.  Have a light snack.  When everything is green and happy, look at
the page again on staging and see that the count has increased by one.  NOTE:
in my QA I didn't see the incremented values reflected immediately which is
really strange.  A few minutes later they were updated.

R=benji
CC=
https://codereview.appspot.com/29960045

Expand All Messages | Collapse All Messages