ICU ticket #12548: adds unit test coverage to uncovered Normalization APIs

ICU ticket #12548: adds unit test coverage to uncovered Normalization APIs

[andy.heninger, 2016-07-21 00:06:42]

https://codereview.appspot.com/299470043/diff/1/main/tests/core/src/com/ibm/i...
File main/tests/core/src/com/ibm/icu/dev/test/normalizer/BasicTest.java (right):

https://codereview.appspot.com/299470043/diff/1/main/tests/core/src/com/ibm/i...
main/tests/core/src/com/ibm/icu/dev/test/normalizer/BasicTest.java:1479: 
Spaces at end of line. Check whole file, there appear to be many cases. I
thought the eclipse project file was set to automatically delete them.

https://codereview.appspot.com/299470043/diff/1/main/tests/core/src/com/ibm/i...
main/tests/core/src/com/ibm/icu/dev/test/normalizer/BasicTest.java:1624:
mode=(Normalizer.Mode)cases2[0][0];
Since there is no loop and only a single test case in cases2, why not just
assign the values for mode, destination, etc. directly?

https://codereview.appspot.com/299470043/diff/1/main/tests/core/src/com/ibm/i...
main/tests/core/src/com/ibm/icu/dev/test/normalizer/BasicTest.java:2902:
assertEquals("Character decomposition failed", null,
tnorm2.getRawDecomposition(c));
Test is fine, but the message seems confusing, since the expected result from
the base class function isn't really doing the advertised operation in the first
place. Maybe "unexpected value returned from Normalizer2.getRawDecomposition()"
or some such. Similar for the other two.

[nrunge, 2016-07-21 23:13:25]

code review changes r39013

[nrunge, 2016-07-21 23:16:23]

https://codereview.appspot.com/299470043/diff/1/main/tests/core/src/com/ibm/i...
File main/tests/core/src/com/ibm/icu/dev/test/normalizer/BasicTest.java (right):

https://codereview.appspot.com/299470043/diff/1/main/tests/core/src/com/ibm/i...
main/tests/core/src/com/ibm/icu/dev/test/normalizer/BasicTest.java:1479: 
On 2016/07/21 00:06:42, andy.heninger wrote:
> Spaces at end of line. Check whole file, there appear to be many cases. I
> thought the eclipse project file was set to automatically delete them.

Done.

https://codereview.appspot.com/299470043/diff/1/main/tests/core/src/com/ibm/i...
main/tests/core/src/com/ibm/icu/dev/test/normalizer/BasicTest.java:1624:
mode=(Normalizer.Mode)cases2[0][0];
On 2016/07/21 00:06:42, andy.heninger wrote:
> Since there is no loop and only a single test case in cases2, why not just
> assign the values for mode, destination, etc. directly?

The array was intended for easier test case extension. Deleted now.

https://codereview.appspot.com/299470043/diff/1/main/tests/core/src/com/ibm/i...
main/tests/core/src/com/ibm/icu/dev/test/normalizer/BasicTest.java:2902:
assertEquals("Character decomposition failed", null,
tnorm2.getRawDecomposition(c));
On 2016/07/21 00:06:42, andy.heninger wrote:
> Test is fine, but the message seems confusing, since the expected result from
> the base class function isn't really doing the advertised operation in the
first
> place. Maybe "unexpected value returned from
Normalizer2.getRawDecomposition()"
> or some such. Similar for the other two.

Done.