Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2721)

Issue 29860044: fakebackend/sandbox no op deployer watches

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by rharding
Modified:
10 years, 5 months ago
Reviewers:
bac, mp+196000
Visibility:
Public.

Description

fakebackend/sandbox no op deployer watches - The fakebackend and the sandbox need to just ignore calls to watch deployer status. It's too fast and we don't want to flood the users with a bunch of notices all at once. - Had to rename the WatchUpdate to deployerNext since the fakebackend auto builds the names of the handle methods based off the actual call. So it needed to be deployerNext though I hate it's no longer worded to tie to 'watch'. QA: Simply deploy a bundle in sandbox mode. - Drag/drop a yaml file into the canvas - Deploy from the deploy button from bundle details Note: Dragging/dropping a bundle token is not working. This is also true on coming soon. This is due to the recent bundle.id tracking code and will be done in a follow up. https://code.launchpad.net/~rharding/juju-gui/bundle-sandbox-noop/+merge/196000 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : fakebackend/sandbox no op deployer watches #

Total comments: 7

Patch Set 3 : fakebackend/sandbox no op deployer watches #

Patch Set 4 : fakebackend/sandbox no op deployer watches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -15 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/assets/javascripts/bundle-import-helpers.js View 1 chunk +2 lines, -2 lines 0 comments Download
M app/store/env/fakebackend.js View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download
M app/store/env/go.js View 2 chunks +8 lines, -8 lines 0 comments Download
M app/store/env/sandbox.js View 1 chunk +27 lines, -0 lines 0 comments Download
M test/test_bundle_import_helpers.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/test_env_go.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_fakebackend.js View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M test/test_sandbox_go.js View 2 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
10 years, 5 months ago (2013-11-20 19:21:45 UTC) #1
bac
LGTM with some crazy nit-picking mess. https://codereview.appspot.com/29860044/diff/20001/app/store/env/fakebackend.js File app/store/env/fakebackend.js (right): https://codereview.appspot.com/29860044/diff/20001/app/store/env/fakebackend.js#newcode1592 app/store/env/fakebackend.js:1592: This method is ...
10 years, 5 months ago (2013-11-20 19:33:20 UTC) #2
rharding
Please take a look.
10 years, 5 months ago (2013-11-20 19:33:38 UTC) #3
rharding
10 years, 5 months ago (2013-11-20 19:42:47 UTC) #4
*** Submitted:

fakebackend/sandbox no op deployer watches

- The fakebackend and the sandbox need to just ignore calls to watch deployer
status. It's too fast and we don't want to flood the users with a bunch of
notices all at once.
- Had to rename the WatchUpdate to deployerNext since the fakebackend auto
builds the names of the handle methods based off the actual call. So it needed
to be deployerNext though I hate it's no longer worded to tie to 'watch'.

QA:

Simply deploy a bundle in sandbox mode.

- Drag/drop a yaml file into the canvas
- Deploy from the deploy button from bundle details

Note: Dragging/dropping a bundle token is not working. This is also true on
coming soon. This is due to the recent bundle.id tracking code and will be
done in a follow up.

R=bac
CC=
https://codereview.appspot.com/29860044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b