Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1142)

Issue 298330043: Issue 4789: Note_performer: articulate events

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by dak
Modified:
7 years, 9 months ago
Reviewers:
ht, Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4789: Note_performer: articulate events Previously, only per-note articulations rather than actual stream events were interpreted in Midi. This change supports articulations on chords or added via simultaneous music.

Patch Set 1 #

Patch Set 2 : Faster to cons than copy a list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M lily/note-performer.cc View 1 5 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Dan Eble
LGTM. Thanks for implementing this.
7 years, 10 months ago (2016-06-02 21:49:25 UTC) #1
dak
Faster to cons than copy a list
7 years, 10 months ago (2016-06-03 05:16:09 UTC) #2
ht
This looks great! Even though this question has little relevance to these code changes, I ...
7 years, 9 months ago (2016-06-05 18:18:23 UTC) #3
dak
7 years, 9 months ago (2016-06-06 10:07:58 UTC) #4
On 2016/06/05 18:18:23, ht wrote:
> This looks great!
> 
> Even though this question has little relevance to these code changes, I can't
> resist asking whether you might have ideas about the best way to fix the
> "reverse" problem of ties attached to *individual notes of a chord* ending up
> ignored when processing articulations using the articulate.ly script:
> 
> ----
> 
> \version "2.19.43"
> 
> \include "articulate.ly"
> 
> \score {
>   \relative c' {
>     <c e g c'>2~ <c e g c'> % OK
>     \articulate { <c e g c'>~ <c e g c'> } % OK
> 
>     <c_~ e_~ g^~ c'^~>2 <c e g c'> % OK
>     \articulate { <c_~ e_~ g^~ c'^~>2 <c e g c'> } % ties are ignored!
>   }
>   \midi { }
> }
> 
> ----
> 
> The fix would in any case have to be made in the Scheme-level music expression
> transformation in the articulate function itself, right?

Well, this change here is basically minimally-invasive and only concerned with
LilyPond's default Midi generation.  My involvement with the articulate script
has been minimal, mostly trying to keep it working when music representation
changed.

If articulate.ly is supposed to get along with LilyPond's Midi generation in the
long haul, it will probably want to remove all articulations that it interprets
in order to avoid having them interpreted doubly.  I have no idea whether it
actually does that.

At any rate, this is an entirely different issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b