Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 297820043: ledger-line-spanner.cc: refactor Ledger_line_spanner::print (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by pwm
Modified:
3 years, 2 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

ledger-line-spanner.cc: refactor Ledger_line_spanner::print Optimizations and removal of code duplication. Only iterate through all note heads once, generating all relevant data for just note heads involved in ledger lines. Then work with that data. Merge overlapping ledger data before producing ledger stencils so we only produce one stencil for each ledger line.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -81 lines) Patch
M lily/ledger-line-spanner.cc View 6 chunks +142 lines, -81 lines 0 comments Download

Messages

Total messages: 1
pwm
3 years, 3 months ago (2016-04-14 15:42:58 UTC) #1
Please review.  I was working on a scheme version of the ledger line print
routine (for some custom ledger line patterns) and having figuring out how it
worked, I thought I would make some improvements.

Since I'm new to C++ ...review is especially appreciated.

Thanks,
-Paul
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b