Issue 297820043: ledger-line-spanner.cc: refactor Ledger_line_spanner::print

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 297820043: ledger-line-spanner.cc: refactor Ledger_line_spanner::print (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years ago by pwm

Modified:
8 years ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

ledger-line-spanner.cc: refactor Ledger_line_spanner::print Optimizations and removal of code duplication. Only iterate through all note heads once, generating all relevant data for just note heads involved in ledger lines. Then work with that data. Merge overlapping ledger data before producing ledger stencils so we only produce one stencil for each ledger line.

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -81 lines)			Patch
	M	lily/ledger-line-spanner.cc	View		6 chunks	+142 lines, -81 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

pwm

8 years ago (2016-04-14 15:42:58 UTC) #1

Please review.  I was working on a scheme version of the ledger line print
routine (for some custom ledger line patterns) and having figuring out how it
worked, I thought I would make some improvements.

Since I'm new to C++ ...review is especially appreciated.

Thanks,
-Paul

Expand All Messages | Collapse All Messages