Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2307)

Issue 296330043: Import various input session variables into parser

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by dak
Modified:
3 years, 6 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Import various input session variables into parser This concerns pitchnames, drumPitchNames, and chordmodifiers, saving a lookup for each use. Also contains commits: Turn pitch-related settings into session variables This concerns pitchnames, default-language, previous-pitchnames, drumPitchNames, and chordmodifiers. Don't overwrite pre-bound session variables This is necessary in order to use session variables in lily-imports.cc

Patch Set 1 #

Patch Set 2 : Protect define-session against double definitions #

Patch Set 3 : Let define-session-public export after all for the sake of other modules #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -43 lines) Patch
M lily/include/lily-imports.hh View 2 chunks +3 lines, -0 lines 0 comments Download
M lily/lily-imports.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M lily/parser.yy View 10 chunks +15 lines, -26 lines 0 comments Download
M scm/chord-entry.scm View 1 chunk +2 lines, -0 lines 0 comments Download
M scm/define-music-display-methods.scm View 1 chunk +1 line, -2 lines 0 comments Download
M scm/define-note-names.scm View 1 chunk +9 lines, -4 lines 0 comments Download
M scm/lily.scm View 1 2 2 chunks +21 lines, -11 lines 0 comments Download

Messages

Total messages: 2
dak
Protect define-session against double definitions
3 years, 6 months ago (2016-06-02 19:48:03 UTC) #1
dak
3 years, 6 months ago (2016-06-03 14:29:26 UTC) #2
Let define-session-public export after all for the sake of other modules
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b