Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(390)

Issue 296310043: Give add_acknowledger SCM &, not Protected_scm & (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by dak
Modified:
1 month ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Give add_acknowledger SCM &, not Protected_scm & This one annoyed me, this looks cleaner. Also contains commit: operator SCM & () for Protected_scm This allows passing SCM reference parameters that are actually based on Protected_scm.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -14 lines) Patch
M lily/include/protected-scm.hh View 1 chunk +3 lines, -1 line 0 comments Download
M lily/include/translator.icc View 1 chunk +1 line, -1 line 0 comments Download
M lily/protected-scm.cc View 3 chunks +24 lines, -10 lines 0 comments Download
M lily/translator.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b