[plaso] Add Twitter iOS plugin #715

[plaso] Add Twitter iOS plugin #715

[Joachim Metz, 2016-05-29 06:08:15]

some style nits

https://codereview.appspot.com/296280043/diff/1/plaso/formatters/twitter_ios.py
File plaso/formatters/twitter_ios.py (right):

https://codereview.appspot.com/296280043/diff/1/plaso/formatters/twitter_ios....
plaso/formatters/twitter_ios.py:7: 
+ style nit: white line

https://codereview.appspot.com/296280043/diff/1/plaso/formatters/twitter_ios....
plaso/formatters/twitter_ios.py:39: Args:
+ white line before Args

https://codereview.appspot.com/296280043/diff/1/plaso/formatters/twitter_ios....
plaso/formatters/twitter_ios.py:43: Returns:
+ white line before Returns

https://codereview.appspot.com/296280043/diff/1/plaso/formatters/twitter_ios....
plaso/formatters/twitter_ios.py:45: Raises:
+ white line before Raises

https://codereview.appspot.com/296280043/diff/1/plaso/formatters/twitter_ios....
plaso/formatters/twitter_ios.py:48: 
- white line

https://codereview.appspot.com/296280043/diff/1/plaso/formatters/twitter_ios....
plaso/formatters/twitter_ios.py:99: """Determines the formatted message strings
for an event object.
same docstring comments as before

https://codereview.appspot.com/296280043/diff/1/plaso/parsers/sqlite_plugins/...
File plaso/parsers/sqlite_plugins/twitter_ios.py (right):

https://codereview.appspot.com/296280043/diff/1/plaso/parsers/sqlite_plugins/...
plaso/parsers/sqlite_plugins/twitter_ios.py:4: SQLite database path:
- indentiation

https://codereview.appspot.com/296280043/diff/1/plaso/parsers/sqlite_plugins/...
plaso/parsers/sqlite_plugins/twitter_ios.py:14: 
+ white line

https://codereview.appspot.com/296280043/diff/1/plaso/parsers/sqlite_plugins/...
plaso/parsers/sqlite_plugins/twitter_ios.py:19: screen_name: Contact's screen
name.
sort alphabetically

https://codereview.appspot.com/296280043/diff/1/plaso/parsers/sqlite_plugins/...
plaso/parsers/sqlite_plugins/twitter_ios.py:19: screen_name: Contact's screen
name.
add type information e.g.

screen_name: a string containing the contact's screen name.

https://codereview.appspot.com/296280043/diff/1/plaso/parsers/sqlite_plugins/...
plaso/parsers/sqlite_plugins/twitter_ios.py:50: self.screen_name = screen_name
sort alphabetically

https://codereview.appspot.com/296280043/diff/1/plaso/parsers/sqlite_plugins/...
plaso/parsers/sqlite_plugins/twitter_ios.py:138: REQUIRED_TABLES =
frozenset([u'Lists', u'MyRetweets', u'StatusesShadow',
why suddenly change indentation? I opt the add an EOL after frozenset([

https://codereview.appspot.com/296280043/diff/1/tests/formatters/twitter_ios.py
File tests/formatters/twitter_ios.py (right):

https://codereview.appspot.com/296280043/diff/1/tests/formatters/twitter_ios....
tests/formatters/twitter_ios.py:9: 
+ whiteline

[Joachim Metz, 2016-05-29 06:08:48]

FYI: https://github.com/log2timeline/plaso/wiki/Style-guide

[jesus, 2016-05-29 18:21:44]

Code updated.

[jesus, 2016-05-29 18:25:17]

Thanks for the review Joachim, PTAL

P.S. The Google Python Style Guide link is broken. we need to update it to
https://google.github.io/styleguide/pyguide.html

https://codereview.appspot.com/296280043/diff/1/plaso/formatters/twitter_ios.py
File plaso/formatters/twitter_ios.py (right):

https://codereview.appspot.com/296280043/diff/1/plaso/formatters/twitter_ios....
plaso/formatters/twitter_ios.py:7: 
On 2016/05/29 06:08:14, Joachim Metz wrote:
> + style nit: white line

Done.

https://codereview.appspot.com/296280043/diff/1/plaso/formatters/twitter_ios....
plaso/formatters/twitter_ios.py:39: Args:
On 2016/05/29 06:08:14, Joachim Metz wrote:
> + white line before Args

Done.

https://codereview.appspot.com/296280043/diff/1/plaso/formatters/twitter_ios....
plaso/formatters/twitter_ios.py:43: Returns:
On 2016/05/29 06:08:14, Joachim Metz wrote:
> + white line before Returns

Done.

https://codereview.appspot.com/296280043/diff/1/plaso/formatters/twitter_ios....
plaso/formatters/twitter_ios.py:45: Raises:
On 2016/05/29 06:08:14, Joachim Metz wrote:
> + white line before Raises

Done.

https://codereview.appspot.com/296280043/diff/1/plaso/formatters/twitter_ios....
plaso/formatters/twitter_ios.py:48: 
On 2016/05/29 06:08:14, Joachim Metz wrote:
> - white line

Done.

https://codereview.appspot.com/296280043/diff/1/plaso/formatters/twitter_ios....
plaso/formatters/twitter_ios.py:99: """Determines the formatted message strings
for an event object.
On 2016/05/29 06:08:14, Joachim Metz wrote:
> same docstring comments as before

Done.

https://codereview.appspot.com/296280043/diff/1/plaso/parsers/sqlite_plugins/...
File plaso/parsers/sqlite_plugins/twitter_ios.py (right):

https://codereview.appspot.com/296280043/diff/1/plaso/parsers/sqlite_plugins/...
plaso/parsers/sqlite_plugins/twitter_ios.py:4: SQLite database path:
On 2016/05/29 06:08:14, Joachim Metz wrote:
> - indentiation

Done.

https://codereview.appspot.com/296280043/diff/1/plaso/parsers/sqlite_plugins/...
plaso/parsers/sqlite_plugins/twitter_ios.py:14: 
On 2016/05/29 06:08:14, Joachim Metz wrote:
> + white line

Done.

https://codereview.appspot.com/296280043/diff/1/plaso/parsers/sqlite_plugins/...
plaso/parsers/sqlite_plugins/twitter_ios.py:19: screen_name: Contact's screen
name.
On 2016/05/29 06:08:14, Joachim Metz wrote:
> sort alphabetically

Done.

https://codereview.appspot.com/296280043/diff/1/plaso/parsers/sqlite_plugins/...
plaso/parsers/sqlite_plugins/twitter_ios.py:19: screen_name: Contact's screen
name.
On 2016/05/29 06:08:14, Joachim Metz wrote:
> add type information e.g.
> 
> screen_name: a string containing the contact's screen name.

Done.

https://codereview.appspot.com/296280043/diff/1/plaso/parsers/sqlite_plugins/...
plaso/parsers/sqlite_plugins/twitter_ios.py:50: self.screen_name = screen_name
On 2016/05/29 06:08:14, Joachim Metz wrote:
> sort alphabetically

Done.

https://codereview.appspot.com/296280043/diff/1/plaso/parsers/sqlite_plugins/...
plaso/parsers/sqlite_plugins/twitter_ios.py:138: REQUIRED_TABLES =
frozenset([u'Lists', u'MyRetweets', u'StatusesShadow',
On 2016/05/29 06:08:14, Joachim Metz wrote:
> why suddenly change indentation? I opt the add an EOL after frozenset([

Agree, I blindly followed suggestions from pylint.
Done.

https://codereview.appspot.com/296280043/diff/1/tests/formatters/twitter_ios.py
File tests/formatters/twitter_ios.py (right):

https://codereview.appspot.com/296280043/diff/1/tests/formatters/twitter_ios....
tests/formatters/twitter_ios.py:9: 
On 2016/05/29 06:08:15, Joachim Metz wrote:
> + whiteline

Done.

[onager, 2016-06-01 09:48:32]

https://codereview.appspot.com/296280043/diff/20001/plaso/formatters/twitter_...
File plaso/formatters/twitter_ios.py (right):

https://codereview.appspot.com/296280043/diff/20001/plaso/formatters/twitter_...
plaso/formatters/twitter_ios.py:18: u'Url: {url}',
URL - it's an acronym

https://codereview.appspot.com/296280043/diff/20001/plaso/parsers/sqlite_plug...
File plaso/parsers/sqlite_plugins/twitter_ios.py (right):

https://codereview.appspot.com/296280043/diff/20001/plaso/parsers/sqlite_plug...
plaso/parsers/sqlite_plugins/twitter_ios.py:21: following: An interger value to
describe if the contact is following the
integer

https://codereview.appspot.com/296280043/diff/20001/plaso/parsers/sqlite_plug...
plaso/parsers/sqlite_plugins/twitter_ios.py:26: profile_url: A string containing
the contact's  profile picture url.
URL - and for other instances in comments

[jesus, 2016-06-02 16:40:50]

Code updated.

[jesus, 2016-06-02 16:43:15]

Thanks for the review, comments addressed. PTAL

https://codereview.appspot.com/296280043/diff/20001/plaso/formatters/twitter_...
File plaso/formatters/twitter_ios.py (right):

https://codereview.appspot.com/296280043/diff/20001/plaso/formatters/twitter_...
plaso/formatters/twitter_ios.py:18: u'Url: {url}',
On 2016/06/01 09:48:32, onager wrote:
> URL - it's an acronym

Done.

https://codereview.appspot.com/296280043/diff/20001/plaso/parsers/sqlite_plug...
File plaso/parsers/sqlite_plugins/twitter_ios.py (right):

https://codereview.appspot.com/296280043/diff/20001/plaso/parsers/sqlite_plug...
plaso/parsers/sqlite_plugins/twitter_ios.py:21: following: An interger value to
describe if the contact is following the
On 2016/06/01 09:48:32, onager wrote:
> integer

Done.

https://codereview.appspot.com/296280043/diff/20001/plaso/parsers/sqlite_plug...
plaso/parsers/sqlite_plugins/twitter_ios.py:26: profile_url: A string containing
the contact's  profile picture url.
On 2016/06/01 09:48:32, onager wrote:
> URL - and for other instances in comments

Done.

[onager, 2016-06-02 17:32:07]

On 2016/06/02 16:43:15, jesus wrote:
> Thanks for the review, comments addressed. PTAL
> 
>
https://codereview.appspot.com/296280043/diff/20001/plaso/formatters/twitter_...
> File plaso/formatters/twitter_ios.py (right):
> 
>
https://codereview.appspot.com/296280043/diff/20001/plaso/formatters/twitter_...
> plaso/formatters/twitter_ios.py:18: u'Url: {url}',
> On 2016/06/01 09:48:32, onager wrote:
> > URL - it's an acronym
> 
> Done.
> 
>
https://codereview.appspot.com/296280043/diff/20001/plaso/parsers/sqlite_plug...
> File plaso/parsers/sqlite_plugins/twitter_ios.py (right):
> 
>
https://codereview.appspot.com/296280043/diff/20001/plaso/parsers/sqlite_plug...
> plaso/parsers/sqlite_plugins/twitter_ios.py:21: following: An interger value
to
> describe if the contact is following the
> On 2016/06/01 09:48:32, onager wrote:
> > integer
> 
> Done.
> 
>
https://codereview.appspot.com/296280043/diff/20001/plaso/parsers/sqlite_plug...
> plaso/parsers/sqlite_plugins/twitter_ios.py:26: profile_url: A string
containing
> the contact's  profile picture url.
> On 2016/06/01 09:48:32, onager wrote:
> > URL - and for other instances in comments
> 
> Done.

OK, this LGTM. I'll merge it in a sec.

[onager, 2016-06-02 17:46:31]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close feature