ICU ticket #12520: Collator.getKeywordValuesForLocale() resource data enumeration

ICU ticket #12520: Collator.getKeywordValuesForLocale() resource data enumeration

[markus.icu, 2016-04-28 21:40:01]

https://codereview.appspot.com/296080043/diff/1/main/classes/collate/src/com/...
File main/classes/collate/src/com/ibm/icu/text/Collator.java (right):

https://codereview.appspot.com/296080043/diff/1/main/classes/collate/src/com/...
main/classes/collate/src/com/ibm/icu/text/Collator.java:20: import
com.ibm.icu.impl.UResource.Key;
I just noticed this and the next import, removed them, and qualified these
below.

[markus.icu, 2016-04-29 18:46:07]

simpler, shorter

[fabalbon, 2016-04-29 21:17:08]

LGTM

https://codereview.appspot.com/296080043/diff/1/main/classes/collate/src/com/...
File main/classes/collate/src/com/ibm/icu/text/Collator.java (right):

https://codereview.appspot.com/296080043/diff/1/main/classes/collate/src/com/...
main/classes/collate/src/com/ibm/icu/text/Collator.java:20: import
com.ibm.icu.impl.UResource.Key;
On 2016/04/28 21:40:00, markus.icu wrote:
> I just noticed this and the next import, removed them, and qualified these
> below.

Acknowledged.

https://codereview.appspot.com/296080043/diff/20001/main/classes/collate/src/...
File main/classes/collate/src/com/ibm/icu/text/Collator.java (right):

https://codereview.appspot.com/296080043/diff/20001/main/classes/collate/src/...
main/classes/collate/src/com/ibm/icu/text/Collator.java:995: return
sink.values.toArray(EMPTY_STRING_ARRAY);
What do you think about:
String[] keywords = new String[sink.values.size()];
return sink.values.toArray(keywords);

The internal implementation of LinkedList.toArray(T[]) has this:
 1083       public <T> T[] toArray(T[] a) {
 1084           if (a.length < size)
 1085               a = (T[])java.lang.reflect.Array.newInstance(
 1086                                   a.getClass().getComponentType(), size);

I don't think that this will have an effect in the performance, but using a full
size array or maybe casting the paremeterless .toArray() looks better :)

[markus.icu, 2016-04-29 21:47:03]

give toArray() a full-length destination array

[markus.icu, 2016-04-29 21:48:18]

https://codereview.appspot.com/296080043/diff/20001/main/classes/collate/src/...
File main/classes/collate/src/com/ibm/icu/text/Collator.java (right):

https://codereview.appspot.com/296080043/diff/20001/main/classes/collate/src/...
main/classes/collate/src/com/ibm/icu/text/Collator.java:995: return
sink.values.toArray(EMPTY_STRING_ARRAY);
Done

I don't know which is "better" or more efficient, but now it is 2 lines
shorter...

[fabalbon, 2016-04-29 22:04:40]

LGTM

https://codereview.appspot.com/296080043/diff/20001/main/classes/collate/src/...
File main/classes/collate/src/com/ibm/icu/text/Collator.java (right):

https://codereview.appspot.com/296080043/diff/20001/main/classes/collate/src/...
main/classes/collate/src/com/ibm/icu/text/Collator.java:995: return
sink.values.toArray(EMPTY_STRING_ARRAY);
On 2016/04/29 21:48:18, markus.icu wrote:
> Done
> 
> I don't know which is "better" or more efficient, but now it is 2 lines
> shorter...

Acknowledged.