Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3075)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 295930043: [dfvfs] Added fake file system builder helper. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by Joachim Metz
Modified:
7 years, 11 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfvfs] Added fake file system builder helper.

Patch Set 1 : Added fake file system builder helper. #

Total comments: 4

Patch Set 2 : Changes after review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -20 lines) Patch
A dfvfs/helpers/fake_file_system_builder.py View 1 1 chunk +122 lines, -0 lines 0 comments Download
M dfvfs/vfs/fake_file_system.py View 1 6 chunks +25 lines, -5 lines 0 comments Download
M dfvfs/vfs/file_entry.py View 1 2 chunks +13 lines, -7 lines 0 comments Download
A tests/helpers/fake_file_system_builder.py View 1 1 chunk +77 lines, -0 lines 0 comments Download
M tests/helpers/file_system_searcher.py View 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib/ewf.py View 1 2 chunks +0 lines, -4 lines 0 comments Download
M tests/lib/raw.py View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8
Joachim Metz
8 years ago (2016-04-18 18:18:34 UTC) #1
Joachim Metz
https://codereview.appspot.com/295930043/diff/1/dfvfs/helpers/fake_file_system_builder.py File dfvfs/helpers/fake_file_system_builder.py (right): https://codereview.appspot.com/295930043/diff/1/dfvfs/helpers/fake_file_system_builder.py#newcode69 dfvfs/helpers/fake_file_system_builder.py:69: Note to self: Add AddFileWithContent method.
8 years ago (2016-04-18 18:32:42 UTC) #2
Joachim Metz
Code updated.
8 years ago (2016-04-18 18:41:57 UTC) #3
onager
https://codereview.appspot.com/295930043/diff/20001/dfvfs/helpers/fake_file_system_builder.py File dfvfs/helpers/fake_file_system_builder.py (right): https://codereview.appspot.com/295930043/diff/20001/dfvfs/helpers/fake_file_system_builder.py#newcode32 dfvfs/helpers/fake_file_system_builder.py:32: if not self.file_system.FileEntryExistsByPath(parent_path): If there's a non-directory file entry ...
7 years, 12 months ago (2016-04-28 11:22:52 UTC) #4
Joachim Metz
Code updated.
7 years, 12 months ago (2016-04-29 04:21:13 UTC) #5
Joachim Metz
https://codereview.appspot.com/295930043/diff/20001/dfvfs/helpers/fake_file_system_builder.py File dfvfs/helpers/fake_file_system_builder.py (right): https://codereview.appspot.com/295930043/diff/20001/dfvfs/helpers/fake_file_system_builder.py#newcode32 dfvfs/helpers/fake_file_system_builder.py:32: if not self.file_system.FileEntryExistsByPath(parent_path): Good catch, this was not that ...
7 years, 12 months ago (2016-04-29 04:30:28 UTC) #6
onager
LGTM
7 years, 11 months ago (2016-05-10 04:58:32 UTC) #7
Joachim Metz
7 years, 11 months ago (2016-05-10 05:00:50 UTC) #8 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close fakefsbuilder
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b