Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4946)

Issue 295600043: Set rhythmic-location early in paper-column-engraver (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by dak
Modified:
2 years, 4 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Set rhythmic-location early in paper-column-engraver This makes it possible to refer to rhythmic-location in callbacks for PaperColumn grobs. This one annoyed me when I was experimenting with line-break related callbacks. While the problem I was working on was ultimately better solved using an engraver rather than a callback, there does not seem to be a point in setting the "rhythmic-location" property much later than "when".

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M lily/paper-column-engraver.cc View 2 chunks +12 lines, -12 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b