Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5453)

Issue 295450043: i#1941 vpshufb: Give vpshufb 3 operands, not 2

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by rocallahan
Modified:
7 years, 10 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1941 vpshufb: Give vpshufb 3 operands, not 2 Fixes #1941 ---------------

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M core/arch/x86/decode_table.c View 1 chunk +1 line, -1 line 0 comments Download
M core/arch/x86/instr_create.h View 2 chunks +2 lines, -2 lines 0 comments Download
M suite/tests/api/ir_x86_2args_mm.h View 2 chunks +0 lines, -2 lines 0 comments Download
M suite/tests/api/ir_x86_3args.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7
rocallahan
7 years, 11 months ago (2016-06-02 03:36:30 UTC) #1
bruening
Thank you for the bug report and patch. I do not see rocallahan at gmail ...
7 years, 11 months ago (2016-06-02 17:01:49 UTC) #2
rocallahan
On 2016/06/02 17:01:49, bruening wrote: > Thank you for the bug report and patch. I ...
7 years, 11 months ago (2016-06-02 23:47:34 UTC) #3
bruening
LGTM I can add you as a committer and you can commit this directly, if ...
7 years, 10 months ago (2016-06-03 15:54:42 UTC) #4
rocallahan
I haven't tried running the precommit test suite yet. I'll do that and then get ...
7 years, 10 months ago (2016-06-03 22:31:02 UTC) #5
rocallahan
Ah, I realize now that Commit-Criteria requires tests to be run on Windows. I don't ...
7 years, 10 months ago (2016-06-04 22:37:55 UTC) #6
bruening
7 years, 10 months ago (2016-06-07 18:27:52 UTC) #7
On 2016/06/04 22:37:55, rocallahan wrote:
> Ah, I realize now that Commit-Criteria requires tests to be run on Windows. I
> don't have a Windows setup so it'll be a lot more work for me to get that up
and
> running. Can I opt out of that and ask you to commit for me?

OK, will do.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b