Issue 295400043: Fixed darwin plugins which used the wrong method of accessing efilter results.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 295400043: Fixed darwin plugins which used the wrong method of accessing efilter results. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 11 months ago by scudette

Modified:
7 years, 11 months ago

Reviewers:
the80srobot

CC:
rekall-dev_googlegroups.com

Base URL:
https://github.com/google/rekall.git@master

Visibility:
Public.

More Reviews

Description

Fixed darwin plugins which used the wrong method of accessing efilter results. R=adam.sindelar@gmail.com Committed: 0cfc7369bad5fb17e59326ba05f29806f767515c

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
M	rekall-core/rekall/plugins/common/search.py	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	rekall-core/rekall/plugins/darwin/zones.py	View	2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	rekall-core/rekall/ui/text.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

the80srobot

lgtm, even though you didn't ask. Also, we could just implement IAssociative for those types, ...

7 years, 11 months ago (2016-05-30 19:09:08 UTC) #1

scudette

Committed patchset #4 (id:60001) manually as 0cfc7369bad5fb17e59326ba05f29806f767515c (presubmit successful).

7 years, 11 months ago (2016-06-01 07:00:37 UTC) #2

scudette

On 2016/05/30 19:09:08, the80srobot wrote: > lgtm, even though you didn't ask. > > Also, ...

7 years, 11 months ago (2016-06-01 07:00:37 UTC) #3

scudette

7 years, 11 months ago (2016-06-01 07:00:47 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/295400043/diff/40001/rekall-core/rekall/ui/tex...
File rekall-core/rekall/ui/text.py (right):

https://codereview.appspot.com/295400043/diff/40001/rekall-core/rekall/ui/tex...
rekall-core/rekall/ui/text.py:1408: if (self.table.deferred_rows is not None or
On 2016/05/30 19:09:08, the80srobot wrote:
> Are you sure about this? :)

yes

Expand All Messages | Collapse All Messages