Issue 2948041: Blacklist blackberries from using Array.prototype

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2948041: Blacklist blackberries from using Array.prototype

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by Ilia Mirkin

Modified:
13 years, 5 months ago

Reviewers:

Base URL:
http://closure-library.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Blacklist blackberries from using Array.prototype for functions that take callbacks, since it appears that the closure of functions within the callback functions gets messed up. Add test that demonstrates this. Also blacklist a few more functions that cause the *OmitsDeleted tests to fail otherwise.

Patch Set 1 #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -5 lines)			Patch
M	closure/goog/array/array.js	View	5 chunks	+9 lines, -4 lines	0 comments	Download
M	closure/goog/array/array_test.html	View	2 chunks	+19 lines, -0 lines	0 comments	Download
M	closure/goog/deps.js	View	1 chunk	+1 line, -1 line	0 comments	Download