Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(760)

Issue 294570043: Place barres on fret diagrams if they can be inferred

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by Carl
Modified:
1 year, 5 months ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Place barres on fret diagrams if they can be inferred

Patch Set 1 #

Total comments: 6

Patch Set 2 : Respond to Harm's comments #

Total comments: 1

Patch Set 3 : Remove debug printing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -6 lines) Patch
A Documentation/snippets/new/automatic-fretboards-barre.ly View 1 chunk +22 lines, -0 lines 0 comments Download
M scm/translation-functions.scm View 1 2 3 chunks +50 lines, -6 lines 0 comments Download

Messages

Total messages: 6
thomasmorley651
Hi Carl, nice work. A general thought: As far as I understand the code will ...
1 year, 5 months ago (2018-05-03 22:28:26 UTC) #1
Carl
Harm, Thanks for the great comments. If the user doesn't want the barre to be ...
1 year, 5 months ago (2018-05-04 04:21:53 UTC) #2
Carl
Respond to Harm's comments
1 year, 5 months ago (2018-05-04 13:31:34 UTC) #3
thomasmorley651
Hi Carl, apart from one nit (see below) LGTM Probably not related to this patch: ...
1 year, 5 months ago (2018-05-04 20:09:36 UTC) #4
Carl
Remove debug printing
1 year, 5 months ago (2018-05-05 23:07:45 UTC) #5
thomasmorley651
1 year, 5 months ago (2018-05-06 22:40:20 UTC) #6
On 2018/05/05 23:07:45, Carl wrote:
> Remove debug printing

Very nice! 

LGTM ofcourse

Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b