Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4873)

Issue 2943041: code review 2943041: syscall: use 64-bit file size for truncation on Linux

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by peterGo
Modified:
13 years, 5 months ago
Reviewers:
rsc1
CC:
rsc, golang-dev, royger
Visibility:
Public.

Description

syscall: use 64-bit file size for truncation on Linux Truncate and Ftruncate for 32-bit Linux should use 64-bit offset system calls.

Patch Set 1 #

Patch Set 2 : code review 2943041: syscall: use 64-bit file size for truncation on Linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -50 lines) Patch
M src/pkg/syscall/syscall_linux.go View 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/syscall/syscall_linux_386.go View 2 chunks +2 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_linux_amd64.go View 2 chunks +2 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_linux_arm.go View 2 chunks +2 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_linux_386.go View 4 chunks +16 lines, -16 lines 0 comments Download
M src/pkg/syscall/zsyscall_linux_amd64.go View 4 chunks +16 lines, -16 lines 0 comments Download
M src/pkg/syscall/zsyscall_linux_arm.go View 4 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 5
peterGo
Fixes this error. Error with os.Truncate on Linux http://groups.google.com/group/golang-nuts/msg/f356afdcf99f1bb5
13 years, 5 months ago (2010-11-05 19:49:27 UTC) #1
peterGo
Hello rsc (cc: golang-dev@googlegroups.com, royger@gmail.com), I'd like you to review this change.
13 years, 5 months ago (2010-11-05 19:51:25 UTC) #2
rsc1
LGTM Thanks
13 years, 5 months ago (2010-11-05 20:41:16 UTC) #3
rsc
*** Submitted as 68aae563fd33 *** syscall: use 64-bit file size for truncation on Linux Truncate ...
13 years, 5 months ago (2010-11-05 20:41:28 UTC) #4
rsc
13 years, 5 months ago (2010-11-16 19:27:49 UTC) #5
please send cl requests using hg mail so that golang-dev gets cced.
thanks.

On Fri, Nov 5, 2010 at 15:49,  <go.peter.90@gmail.com> wrote:
> Reviewers: rsc,
>
> Message:
> Fixes this error.
>
> Error with os.Truncate on Linux
> http://groups.google.com/group/golang-nuts/msg/f356afdcf99f1bb5
>
> Description:
> syscall: use 64-bit file size for truncation on Linux
>
> Truncate and Ftruncate for 32-bit Linux should use 64-bit
> offset system calls.
>
> Please review this at http://codereview.appspot.com/2943041/
>
> Affected files:
>  M src/pkg/syscall/syscall_linux.go
>  M src/pkg/syscall/syscall_linux_386.go
>  M src/pkg/syscall/syscall_linux_amd64.go
>  M src/pkg/syscall/syscall_linux_arm.go
>  M src/pkg/syscall/zsyscall_linux_386.go
>  M src/pkg/syscall/zsyscall_linux_amd64.go
>  M src/pkg/syscall/zsyscall_linux_arm.go
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b