code review 2942042: testing: rename type Test to InternalTest

testing: rename type Test to InternalTest

type Benchmark has been renamed to InternalBenchmark

[peterGo, 2010-11-05 20:41:40]

"Consistency is the foundation of virtue." - Francis Bacon

[peterGo, 2010-11-05 20:42:57]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-11-06 03:04:32]

LGTM

[rsc, 2010-11-06 03:05:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=3bfd5efda9e3 ***

testing: rename type Test to InternalTest

type Benchmark has been renamed to InternalBenchmark

R=rsc
CC=golang-dev
http://codereview.appspot.com/2942042

Committer: Russ Cox <rsc@golang.org>

[rsc, 2010-11-16 19:27:36]

please send CL requests using hg mail so that
golang-dev gets cc'ed.

thanks.


On Fri, Nov 5, 2010 at 16:41,  <go.peter.90@gmail.com> wrote:
> Reviewers: rsc,
>
> Message:
> "Consistency is the foundation of virtue." - Francis Bacon
>
> Description:
> testing: rename type Test to InternalTest
>
> type Benchmark has been renamed to InternalBenchmark
>
> Please review this at http://codereview.appspot.com/2942042/
>
> Affected files:
>  M src/cmd/gotest/gotest
>  M src/pkg/testing/testing.go
>
>
> Index: src/cmd/gotest/gotest
> ===================================================================
> --- a/src/cmd/gotest/gotest
> +++ b/src/cmd/gotest/gotest
> @@ -150,7 +150,7 @@
>        echo 'import __regexp__ "regexp"' # rename in case tested package is
> called regexp
>        # test array
>        echo
> -       echo 'var tests = []testing.Test{'
> +       echo 'var tests = []testing.InternalTest{'
>        for i in $tests
>        do
>                echo '  {"'$i'", '$i'},'
> Index: src/pkg/testing/testing.go
> ===================================================================
> --- a/src/pkg/testing/testing.go
> +++ b/src/pkg/testing/testing.go
> @@ -123,19 +123,19 @@
>
>  // An internal type but exported because it is cross-package; part of the
> implementation
>  // of gotest.
> -type Test struct {
> +type InternalTest struct {
>        Name string
>        F    func(*T)
>  }
>
> -func tRunner(t *T, test *Test) {
> +func tRunner(t *T, test *InternalTest) {
>        test.F(t)
>        t.ch <- t
>  }
>
>  // An internal function but exported because it is cross-package; part of
> the implementation
>  // of gotest.
> -func Main(matchString func(pat, str string) (bool, os.Error), tests []Test)
> {
> +func Main(matchString func(pat, str string) (bool, os.Error), tests
> []InternalTest) {
>        flag.Parse()
>        ok := true
>        if len(tests) == 0 {
>
>
>