Issue 29400043: Adds agent_state_data(SourceData) support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29400043: Adds agent_state_data(SourceData) support

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by jeff.pihach

Modified:
10 years, 5 months ago

Reviewers:
mp+195896

Visibility:
Public.

Description

Adds agent_state_data(SourceData) support The simulator and juju-core return SourceData along with any error messages. These are now displayed in the unit details left breakout panel in the new inspector. I also removed an unused template from the old inspectors and modified some css to make the left panel react properly to varying unit detail header heights. https://code.launchpad.net/~hatch/juju-gui/agent-data-support/+merge/195896 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Adds agent_state_data(SourceData) support #

Patch Set 3 : Adds agent_state_data(SourceData) support #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -172 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/models/handlers.js	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	app/models/models.js	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	app/store/env/sandbox.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	app/store/env/simulator.js	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
D	app/templates/unit.handlebars	View		1 chunk	+0 lines, -116 lines	0 comments	Download
M	app/templates/unitOverview.handlebars	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	app/views/utils.js	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	app/views/viewlets/unit-details.js	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	lib/views/juju-inspector.less	View		2 chunks	+9 lines, -6 lines	0 comments	Download
M	test/test_utils.js	View		1 chunk	+0 lines, -33 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

matthew.scott

Code's good, will see about QA later unless someone else snags it.

10 years, 5 months ago (2013-11-20 01:32:00 UTC) #2

gary.poster

On 2013/11/20 01:32:00, matthew.scott wrote: > Code's good, will see about QA later unless someone ...

10 years, 5 months ago (2013-11-20 14:56:52 UTC) #3

gary.poster

On 2013/11/20 14:56:52, gary.poster wrote: > On 2013/11/20 01:32:00, matthew.scott wrote: > > Code's good, ...

10 years, 5 months ago (2013-11-20 14:57:06 UTC) #4

jeff.pihach

10 years, 5 months ago (2013-11-20 15:25:30 UTC) #5

*** Submitted:

Adds agent_state_data(SourceData) support

The simulator and juju-core return SourceData along with any
error messages. These are now displayed in the unit details
left breakout panel in the new inspector.

I also removed an unused template from the old inspectors and
modified some css to make the left panel react properly to
varying unit detail header heights.

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/29400043

Expand All Messages | Collapse All Messages