Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(661)

Issue 293290043: FQ-CoDel queue disc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by Pasquale Imputato
Modified:
7 years, 4 months ago
Reviewers:
dave.taht, Tom Henderson, mrichart, tomh, Stefano Avallone
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

FQ-CoDel queue disc

Patch Set 1 #

Total comments: 26

Patch Set 2 : Updated version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1397 lines, -0 lines) Patch
M doc/models/Makefile View 1 1 chunk +1 line, -0 lines 0 comments Download
M doc/models/source/traffic-control.rst View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/internet/model/ipv4-packet-filter.h View 1 2 chunks +26 lines, -0 lines 0 comments Download
M src/internet/model/ipv4-packet-filter.cc View 1 2 chunks +89 lines, -0 lines 0 comments Download
M src/internet/model/ipv6-packet-filter.h View 1 2 chunks +26 lines, -0 lines 0 comments Download
M src/internet/model/ipv6-packet-filter.cc View 1 2 chunks +88 lines, -0 lines 0 comments Download
A src/internet/test/fq-codel-queue-disc-test-suite.cc View 1 1 chunk +493 lines, -0 lines 0 comments Download
M src/internet/wscript View 1 1 chunk +1 line, -0 lines 0 comments Download
A src/traffic-control/doc/fq-codel.rst View 1 1 chunk +112 lines, -0 lines 0 comments Download
A src/traffic-control/model/fq-codel-queue-disc.h View 1 1 chunk +162 lines, -0 lines 0 comments Download
A src/traffic-control/model/fq-codel-queue-disc.cc View 1 1 chunk +396 lines, -0 lines 0 comments Download
M src/traffic-control/wscript View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15
Pasquale Imputato
Hi all, we have created a review request about the introduction of FQ-CoDel queue disc ...
7 years, 11 months ago (2016-04-27 17:06:13 UTC) #1
Stefano Avallone
Just to point out that this implementation requires: - the fix proposed for bug #2384: ...
7 years, 11 months ago (2016-04-27 17:37:24 UTC) #2
dave.taht
I am happy to see this re-re-landing again. If there is a tree I can ...
7 years, 11 months ago (2016-04-27 23:23:51 UTC) #3
Stefano Avallone
On 2016/04/27 23:23:51, dave.taht wrote: > I am happy to see this re-re-landing again. Yeah, ...
7 years, 11 months ago (2016-04-28 07:57:54 UTC) #4
Stefano Avallone
On 2016/04/28 07:57:54, Stefano Avallone wrote: > Sure, you can git clone from here: > ...
7 years, 11 months ago (2016-04-28 08:03:24 UTC) #5
dave.taht
There was a "rrul" like test program in the original patch set, 4 up, 4 ...
7 years, 9 months ago (2016-06-26 06:29:32 UTC) #6
Tom Henderson
I'd like to see a bit more work on this before merging. - finish class ...
7 years, 8 months ago (2016-07-17 22:13:56 UTC) #7
Stefano Avallone
Here it is an updated version that addresses your comments. Please browse the previous version ...
7 years, 8 months ago (2016-07-19 15:02:35 UTC) #8
Tom Henderson
On 2016/07/19 15:02:35, Stefano Avallone wrote: > Here it is an updated version that addresses ...
7 years, 8 months ago (2016-08-01 05:46:27 UTC) #9
dave.taht
On 2016/08/01 05:46:27, Tom Henderson wrote: > On 2016/07/19 15:02:35, Stefano Avallone wrote: > > ...
7 years, 7 months ago (2016-08-10 09:54:04 UTC) #10
Stefano Avallone
Hi Dave, I pushed not only FQ-CoDel, but also PIE and BQL to ns-3-dev. Bests, ...
7 years, 7 months ago (2016-08-10 11:23:09 UTC) #11
dave.taht
I am pretty sure that kissing you on both cheeks is appropo at this point. ...
7 years, 7 months ago (2016-08-10 11:31:55 UTC) #12
tomh_tomh.org
On 08/10/2016 04:31 AM, Dave Taht wrote: > I am pretty sure that kissing you ...
7 years, 7 months ago (2016-08-10 15:21:18 UTC) #13
dave.taht
Kisses on all cheeks all around (where culturally accepted) ! (Didn't mean to leave anyone ...
7 years, 7 months ago (2016-08-10 15:24:48 UTC) #14
Stefano Avallone
7 years, 7 months ago (2016-08-10 15:45:27 UTC) #15
My fault that I did not thank Pasquale and Mohit. Of course, alone I couldn't
have done all of this!

Another news that might be of interest to Dave is that ns-3 now supports packet
priorities and setting the user priority (and selecting the access category) for
wifi based on the DSCP like Linux currently does (I.e., taking the 3 most
significant bits). So, 802.11 EDCA can be fully stressed! I am aware there is an
IETF draft proposing a different DSCP to UP mapping: I will implement it as soon
as it gets finalized.

Happy birthday 🙂

Stefano


On August 10, 2016 5:24:47 PM GMT+02:00, Dave Taht <dave.taht@gmail.com> wrote:
>Kisses on all cheeks all around (where culturally accepted) !
>
>(Didn't mean to leave anyone out sorry!)
>
>On Aug 10, 2016 5:21 PM, "Tom Henderson" <tomh@tomh.org> wrote:
>
>> On 08/10/2016 04:31 AM, Dave Taht wrote:
>>
>>> I am pretty sure that kissing you on both cheeks is appropo at this
>point.
>>>
>>> THANK YOU VERY VERY VERY VERY VERY VERY MUCH!
>>>
>>
>> Hi Dave,
>> Stefano has indeed done a great job leading the effort to mainline
>traffic
>> control and AQM models this year.  Let's also thank Pasquale Imputato
>> (FQ-CoDel, BQL) and Mohit Tahiliani and his students (PIE) for their
>work
>> on the individual models.   You can read more about these
>implementations
>> at:
>>
>> traffic control:  http://dl.acm.org/citation.cfm?id=2915382
>>
>> PIE:  http://dl.acm.org/citation.cfm?id=2915385
>>
>> - Tom
>>

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b