Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3846)

Issue 292850043: Fix bad Proxy feature test in ES5/3. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by kpreid_google
Modified:
8 years ago
Reviewers:
x-a-x, MarkM
CC:
google-caja-discuss_googlegroups.com
Visibility:
Public.

Description

The previous test assumed that if Proxy exists, Proxy.create also exists, which is not necessarily the case these days. @ 78af8b82e56f9cab2f899d0ef22c912afb603810

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/com/google/caja/es53.js View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 9
kpreid_google
8 years, 1 month ago (2016-03-09 18:41:52 UTC) #1
MarkM
LGTM https://codereview.appspot.com/292850043/diff/1/src/com/google/caja/es53.js File src/com/google/caja/es53.js (right): https://codereview.appspot.com/292850043/diff/1/src/com/google/caja/es53.js#newcode4399 src/com/google/caja/es53.js:4399: var nativeProxies = Proxy && Proxy.create && (function ...
8 years, 1 month ago (2016-03-09 18:55:40 UTC) #2
kpreid_google
https://codereview.appspot.com/292850043/diff/1/src/com/google/caja/es53.js File src/com/google/caja/es53.js (right): https://codereview.appspot.com/292850043/diff/1/src/com/google/caja/es53.js#newcode4399 src/com/google/caja/es53.js:4399: var nativeProxies = Proxy && Proxy.create && (function () ...
8 years, 1 month ago (2016-03-09 18:59:22 UTC) #3
MarkM
On 2016/03/09 18:59:22, kpreid_google wrote: > https://codereview.appspot.com/292850043/diff/1/src/com/google/caja/es53.js > File src/com/google/caja/es53.js (right): > > https://codereview.appspot.com/292850043/diff/1/src/com/google/caja/es53.js#newcode4399 > ...
8 years, 1 month ago (2016-03-09 19:00:07 UTC) #4
x-a-x
8 years ago (2016-04-06 09:21:07 UTC) #5
x-a-x
8 years ago (2016-04-06 09:21:08 UTC) #6
x-a-x
8 years ago (2016-04-06 09:21:13 UTC) #7
x-a-x
8 years ago (2016-04-06 09:21:14 UTC) #8
x-a-x
8 years ago (2016-04-06 09:21:15 UTC) #9
Message was sent while issue was closed.

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b