Issue 292610043: TBR: i#1885: false pos in TppIsWorkerThread

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 292610043: TBR: i#1885: false pos in TppIsWorkerThread

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 11 months ago by bruening

Modified:
8 years, 11 months ago

Reviewers:
zhaoqin

CC:
drmemory-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1885: false pos in TppIsWorkerThread Adds handling of the special extra write in NtQueryInformationThread.ThreadTebInformation. Fixes #1885 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -1 line)			Patch
M	drsyscall/drsyscall_windows.c	View	5 chunks	+24 lines, -0 lines	0 comments	Download
M	drsyscall/table_windows_ntoskrnl.c	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	wininc/ndk_psfuncs.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	wininc/ntpsapi.h	View	2 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

8 years, 11 months ago (2016-05-02 05:10:57 UTC) #2

Committed as
https://github.com/DynamoRIO/drmemory/commit/72067db32fdb2bdfd6a9e442a83979fd...

Final commit log: 
---------------
i#1885: false pos in TppIsWorkerThread

Adds handling of the special extra write in
NtQueryInformationThread.ThreadTebInformation.

Fixes #1885

Review-URL: https://codereview.appspot.com/292610043
---------------

Expand All Messages | Collapse All Messages