Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1139)

Issue 2915041: Accept proxy username and password in http(s)_proxy env variable (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by Tom Miller
Modified:
3 years, 5 months ago
Reviewers:
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Fixes bugs in original patch for issue 2915041 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M src/atom/http.py View 1 2 chunks +31 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Tom Miller
3 years, 5 months ago #1
Tom Miller
3 years, 5 months ago #2
jcgregorio
LGTM
3 years, 5 months ago #3
Tom Miller
3 years, 5 months ago #4
On 2010/11/05 17:49:57, jcgregorio wrote:
> LGTM

The patch in this issue was submitted, but the patch did not fix the issue in
its entirety.  Another issue was opened here:
http://codereview.appspot.com/2945041/ which should fully allow proxy
authentication info in http(s)_proxy.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5