Issue 2915041: Accept proxy username and password in http(s)_proxy env variable

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2915041: Accept proxy username and password in http(s)_proxy env variable (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by Tom Miller

Modified:
13 years, 5 months ago

Reviewers:

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Fixes bugs in original patch for issue 2915041 #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -2 lines)			Patch
	M	src/atom/http.py	View	1	2 chunks	+31 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Tom Miller

13 years, 5 months ago (2010-11-12 19:41:00 UTC) #4

On 2010/11/05 17:49:57, jcgregorio wrote:
> LGTM

The patch in this issue was submitted, but the patch did not fix the issue in
its entirety.  Another issue was opened here:
http://codereview.appspot.com/2945041/ which should fully allow proxy
authentication info in http(s)_proxy.

Expand All Messages | Collapse All Messages