Issue 291170043: Dump HKDF intermediate values

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 291170043: Dump HKDF intermediate values (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 1 month ago by ekr-rietveld

Modified:
8 years, 1 month ago

Reviewers:
mt

Visibility:
Public.

More Reviews

Patch Set 2 : Update indent #

Total comments: 8

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -1 line)			Patch
M	lib/ssl/sslimpl.h	View	1	2 chunks	+3 lines, -0 lines	2 comments	Download
M	lib/ssl/ssltrace.c	View		2 chunks	+20 lines, -0 lines	0 comments	Download
M	lib/ssl/tls13con.c	View		1 chunk	+3 lines, -0 lines	4 comments	Download
M	lib/ssl/tls13hkdf.c	View		3 chunks	+19 lines, -1 line	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Patch Set 2 LGTM Nits only https://codereview.appspot.com/291170043/diff/20001/lib/ssl/sslimpl.h File lib/ssl/sslimpl.h (right): https://codereview.appspot.com/291170043/diff/20001/lib/ssl/sslimpl.h#newcode89 lib/ssl/sslimpl.h:89: #define PRINT_KEY(a, b) ...

8 years, 1 month ago (2016-03-14 00:14:18 UTC) #2

ekr-rietveld

8 years, 1 month ago (2016-03-14 12:14:24 UTC) #3

https://codereview.appspot.com/291170043/diff/20001/lib/ssl/sslimpl.h
File lib/ssl/sslimpl.h (right):

https://codereview.appspot.com/291170043/diff/20001/lib/ssl/sslimpl.h#newcode89
lib/ssl/sslimpl.h:89: #define PRINT_KEY(a, b) if (ssl_trace >= (a)) ssl_PrintKey
b
On 2016/03/14 00:14:17, mt wrote:
> Nit: wrap like the lines above, since that is what clang-format will end up
> doing.  Though maybe the indent there can be fixed.

Done.

https://codereview.appspot.com/291170043/diff/20001/lib/ssl/tls13con.c
File lib/ssl/tls13con.c (right):

https://codereview.appspot.com/291170043/diff/20001/lib/ssl/tls13con.c#newcod...
lib/ssl/tls13con.c:1275: 
On 2016/03/14 00:14:18, mt wrote:
> extra blank line

Done.

https://codereview.appspot.com/291170043/diff/20001/lib/ssl/tls13con.c#newcod...
lib/ssl/tls13con.c:1277: PRINT_BUF(90, (NULL, "Context string", context_string,
strlen(context_string)));
On 2016/03/14 00:14:18, mt wrote:
> Why omit the socket argument here?  You have one.

https://codereview.appspot.com/291170043/diff/20001/lib/ssl/tls13hkdf.c
File lib/ssl/tls13hkdf.c (right):

https://codereview.appspot.com/291170043/diff/20001/lib/ssl/tls13hkdf.c#newco...
lib/ssl/tls13hkdf.c:174: SSL_TRC(60, ("HKDF Expand: label=[TLS 1.3, ] +
'%s',requested length=%d",
On 2016/03/14 00:14:18, mt wrote:
> Why not just "... label='TLS 1.3, %s',requested ..."

Because I wanted to indicate the data that I wasactually using here. And the TLS
1.3 is inserted separately

Expand All Messages | Collapse All Messages