Update simulator to support juju-core style error

Update simulator to support juju-core style error

The simulator was reporting errors in the old pyjuju format.
With the new failtester charm we can now get the real juju-core
error information. The simulator was updated to report the
real errors in the real format to match juju-core.

https://code.launchpad.net/~hatch/juju-gui/enhance-simulator-errors/+merge/195808

(do not edit description out of merge proposal)

[jeff.pihach, 2013-11-19 15:45:01]

Please take a look.

[bac, 2013-11-19 16:37:48]

LGTM with suggested changes.
QA A-OK

https://codereview.appspot.com/29070043/diff/1/app/store/env/simulator.js
File app/store/env/simulator.js (right):

https://codereview.appspot.com/29070043/diff/1/app/store/env/simulator.js#new...
app/store/env/simulator.js:161: } else if (roll <= 1) {
Math.random() returns [0, 1) so roll is always <= 1, thus this should just be 
else {...

https://codereview.appspot.com/29070043/diff/1/app/store/env/simulator.js#new...
app/store/env/simulator.js:193: } else if (roll <= 1) {
As above.

https://codereview.appspot.com/29070043/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/29070043/diff/1/app/views/utils.js#newcode1246
app/views/utils.js:1246: // this may no longer be needed because juju-core
returns
This should be an XXX and capitalized.  If you're certain it isn't needed then
just whack it.

[jeff.pihach, 2013-11-19 16:43:55]

Thanks for the review - changes being submitted!

https://codereview.appspot.com/29070043/diff/1/app/store/env/simulator.js
File app/store/env/simulator.js (right):

https://codereview.appspot.com/29070043/diff/1/app/store/env/simulator.js#new...
app/store/env/simulator.js:161: } else if (roll <= 1) {
Right, I was just leaving it in for clarity.

https://codereview.appspot.com/29070043/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/29070043/diff/1/app/views/utils.js#newcode1246
app/views/utils.js:1246: // this may no longer be needed because juju-core
returns
Done - I'm leaving it in, when I update the error reporting in further branches
I'll be able to tell for certain if I can remove.

[jeff.pihach, 2013-11-19 16:48:56]

*** Submitted:

Update simulator to support juju-core style error

The simulator was reporting errors in the old pyjuju format.
With the new failtester charm we can now get the real juju-core
error information. The simulator was updated to report the
real errors in the real format to match juju-core.

R=bac
CC=
https://codereview.appspot.com/29070043