Issue 290130043: Windows build fixes for ChaCha20/Poly1305

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 290130043: Windows build fixes for ChaCha20/Poly1305 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 2 months ago by ttaubert

Modified:
7 years, 11 months ago

Reviewers:
ekr, ekr-rietveld

Visibility:
Public.

More Reviews

Description

Windows build fixes for ChaCha20/Poly1305

Patch Set 1 #

Total comments: 1

Patch Set 2 : Windows build fixes for ChaCha20/Poly1305 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1319 lines)			Patch
M	external_tests/ssl_gtest/ssl_loopback_unittest.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/freebl/Makefile	View		1 chunk	+5 lines, -5 lines	0 comments	Download
A +	lib/freebl/chacha20.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	lib/freebl/chacha20.c	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	lib/freebl/chacha20/chacha20.h	View		1 chunk	+0 lines, -20 lines	0 comments	Download
D	lib/freebl/chacha20/chacha20.c	View		1 chunk	+0 lines, -111 lines	0 comments	Download
D	lib/freebl/chacha20/chacha20_vec.c	View		1 chunk	+0 lines, -278 lines	0 comments	Download
A +	lib/freebl/chacha20_vec.c	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	lib/freebl/chacha20poly1305.c	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	lib/freebl/poly1305.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	lib/freebl/poly1305.c	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	lib/freebl/poly1305-donna-x64-sse2-incremental-source.c	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	lib/freebl/poly1305/poly1305.h	View		1 chunk	+0 lines, -28 lines	0 comments	Download
D	lib/freebl/poly1305/poly1305.c	View		1 chunk	+0 lines, -254 lines	0 comments	Download
D	lib/freebl/poly1305/poly1305-donna-x64-sse2-incremental-source.c	View		1 chunk	+0 lines, -623 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

ekr-rietveld

8 years, 2 months ago (2016-02-09 11:19:30 UTC) #1

The moves look fine but why are you doing a cast instead of fixing the
signature.

https://codereview.appspot.com/290130043/diff/1/external_tests/ssl_gtest/ssl_...
File external_tests/ssl_gtest/ssl_loopback_unittest.cc (right):

https://codereview.appspot.com/290130043/diff/1/external_tests/ssl_gtest/ssl_...
external_tests/ssl_gtest/ssl_loopback_unittest.cc:578:
ConnectSendReceive((int16_t)TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256);
Why does this need a cast? Wouldn't it be better to fix the declaration.

Expand All Messages | Collapse All Messages