Issue 289880043: TBR: i#1445: drcov on Windows: add Windows support for lcov genhtml

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 289880043: TBR: i#1445: drcov on Windows: add Windows support for lcov genhtml

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 3 months ago by zhaoqin

Modified:
8 years, 3 months ago

Reviewers:
boolking, bruening

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1445: drcov on Windows: add Windows support for lcov genhtml - use cwd() instead of system pwd command - use new function mkdirp() instead of system mkdir command - strip colon in path on Windows This patch is contributed by boolking: https://github.com/DynamoRIO/dynamorio/pull/1855 ---------------

Patch Set 1 #

Patch Set 2 : update commit msg #

Patch Set 3 : Committed #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -6 lines)			Patch
	M	third_party/lcov/README.dynamorio	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	third_party/lcov/genhtml	View		9 chunks	+39 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

zhaoqin

Commit log for latest patchset: --------------- i#1445 drcov on Windows: add Windows support for lcov ...

8 years, 3 months ago (2016-01-22 17:03:50 UTC) #2

zhaoqin

8 years, 3 months ago (2016-01-22 20:36:27 UTC) #3

Committed as
https://github.com/DynamoRIO/dynamorio/commit/bf6c5199cebe0015804c7ea6f9bfacc...

Final commit log: 
---------------
i#1445 drcov on Windows: add Windows support for lcov genhtml

- use cwd() instead of system pwd command
- use new function mkdirp() instead of system mkdir command
- strip colon in path on Windows

This patch is contributed by boolking:
https://github.com/DynamoRIO/dynamorio/pull/1855

Review-URL: https://codereview.appspot.com/289880043
---------------

Expand All Messages | Collapse All Messages