Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(853)

Issue 28970043: Added apiaddresses call to agent config

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by mattyw
Modified:
6 years ago
Reviewers:
william.reade, mp+195766, rog
Visibility:
Public.

Description

Added apiaddresses call to agent config Added apiaddresses call with test to agent config https://code.launchpad.net/~mattyw/juju-core/add_apiaddress_to_config/+merge/195766 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Added apiaddresses call to agent config #

Total comments: 1

Patch Set 3 : Added apiaddresses call to agent config #

Patch Set 4 : Added apiaddresses call to agent config #

Total comments: 1

Patch Set 5 : Added apiaddresses call to agent config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M agent/agent.go View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download
M agent/agent_test.go View 1 2 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8
mattyw
Please take a look.
6 years ago (2013-11-19 12:52:43 UTC) #1
william.reade
LGTM
6 years ago (2013-11-19 12:54:13 UTC) #2
william.reade
...actually, LGTM if you copy the addresses slice before returning it.
6 years ago (2013-11-19 12:57:17 UTC) #3
rog
LGTM modulo William's comment. https://codereview.appspot.com/28970043/diff/10001/agent/agent.go File agent/agent.go (right): https://codereview.appspot.com/28970043/diff/10001/agent/agent.go#newcode69 agent/agent.go:69: //APIAddresses returns the addresses needed ...
6 years ago (2013-11-19 13:00:47 UTC) #4
mattyw
Please take a look.
6 years ago (2013-11-19 13:27:21 UTC) #5
mattyw
Please take a look.
6 years ago (2013-11-19 13:29:32 UTC) #6
rog
still LGTM with a tiny simplification suggestion https://codereview.appspot.com/28970043/diff/50001/agent/agent.go File agent/agent.go (right): https://codereview.appspot.com/28970043/diff/50001/agent/agent.go#newcode311 agent/agent.go:311: return apiAdrs, ...
6 years ago (2013-11-19 13:37:11 UTC) #7
mattyw
6 years ago (2013-11-19 13:47:28 UTC) #8
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b