Issue 28970043: Added apiaddresses call to agent config

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 28970043: Added apiaddresses call to agent config

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by mattyw

Modified:
10 years, 5 months ago

Reviewers:
william.reade, mp+195766, rog

Visibility:
Public.

Description

Added apiaddresses call to agent config Added apiaddresses call with test to agent config https://code.launchpad.net/~mattyw/juju-core/add_apiaddress_to_config/+merge/195766 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Added apiaddresses call to agent config #

Total comments: 1

Patch Set 3 : Added apiaddresses call to agent config #

Patch Set 4 : Added apiaddresses call to agent config #

Total comments: 1

Patch Set 5 : Added apiaddresses call to agent config #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	agent/agent.go	View	1 2 3 4	2 chunks	+10 lines, -0 lines	0 comments	Download
M	agent/agent_test.go	View	1 2	2 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

william.reade

...actually, LGTM if you copy the addresses slice before returning it.

10 years, 5 months ago (2013-11-19 12:57:17 UTC) #3

rog

LGTM modulo William's comment. https://codereview.appspot.com/28970043/diff/10001/agent/agent.go File agent/agent.go (right): https://codereview.appspot.com/28970043/diff/10001/agent/agent.go#newcode69 agent/agent.go:69: //APIAddresses returns the addresses needed ...

10 years, 5 months ago (2013-11-19 13:00:47 UTC) #4

rog

still LGTM with a tiny simplification suggestion https://codereview.appspot.com/28970043/diff/50001/agent/agent.go File agent/agent.go (right): https://codereview.appspot.com/28970043/diff/50001/agent/agent.go#newcode311 agent/agent.go:311: return apiAdrs, ...

10 years, 5 months ago (2013-11-19 13:37:11 UTC) #7

Please take a look.

Expand All Messages | Collapse All Messages