Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4094)

Issue 289680043: DR-i#1565: use a future date for VERSION_NUMBER_PATCHLEVEL on git log failure

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by zhaoqin
Modified:
8 years ago
Reviewers:
bruening
CC:
drmemory-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- DR-i#1565: use a future date for VERSION_NUMBER_PATCHLEVEL on git log failure We use a future date for VERSION_NUMBER_PATCHLEVEL instead of fatal error on git log failure. ---------------

Patch Set 1 #

Patch Set 2 : PTAL #

Total comments: 6

Patch Set 3 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M CMakeLists.txt View 1 2 2 chunks +28 lines, -9 lines 0 comments Download

Messages

Total messages: 5
zhaoqin
8 years ago (2016-04-04 18:27:52 UTC) #1
zhaoqin
Commit log for latest patchset: --------------- DR-i#1565: set VERSION_NUMBER_PATCHLEVEL even on git log failure We ...
8 years ago (2016-04-04 21:20:51 UTC) #2
bruening
LGTM w/ comments https://codereview.appspot.com/289680043/diff/20001/CMakeLists.txt File CMakeLists.txt (right): https://codereview.appspot.com/289680043/diff/20001/CMakeLists.txt#newcode184 CMakeLists.txt:184: # We want the committer date ...
8 years ago (2016-04-04 21:26:22 UTC) #3
zhaoqin
https://codereview.appspot.com/289680043/diff/20001/CMakeLists.txt File CMakeLists.txt (right): https://codereview.appspot.com/289680043/diff/20001/CMakeLists.txt#newcode184 CMakeLists.txt:184: # We want the committer date (not author date) ...
8 years ago (2016-04-04 21:33:18 UTC) #4
zhaoqin
8 years ago (2016-04-04 21:35:19 UTC) #5
Committed as
https://github.com/DynamoRIO/drmemory/commit/fe9124b68f30c99d13e49990edf6cad3...

Final commit log: 
---------------
DR-i#1565: set VERSION_NUMBER_PATCHLEVEL even on git log failure

We try different ways to set VERSION_NUMBER_PATCHLEVEL on git log failure.

Review-URL: https://codereview.appspot.com/289680043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b