Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 288690043: TBR: i#1569 AArch64: Make AArch64 build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by Edmund.Grimley.Evans
Modified:
10 years, 6 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- TBR: i#1569 AArch64: Make AArch64 build. It builds, but binaries are non-functional as many things are not yet implemented. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+585 lines, -338 lines) Patch
M api/samples/CMakeLists.txt View 2 chunks +8 lines, -4 lines 0 comments Download
M core/arch/arch.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/arch/arch.c View 11 chunks +15 lines, -9 lines 0 comments Download
M core/arch/arch_exports.h View 10 chunks +50 lines, -9 lines 0 comments Download
M core/arch/asm_defines.asm View 6 chunks +69 lines, -43 lines 0 comments Download
M core/arch/decode.h View 3 chunks +5 lines, -3 lines 0 comments Download
M core/arch/emit_utils_shared.c View 9 chunks +30 lines, -5 lines 0 comments Download
M core/arch/instr.h View 4 chunks +5 lines, -1 line 0 comments Download
M core/arch/instr_create_shared.h View 1 chunk +2 lines, -0 lines 0 comments Download
M core/arch/instr_inline.h View 3 chunks +8 lines, -4 lines 0 comments Download
M core/arch/instr_shared.c View 7 chunks +15 lines, -5 lines 0 comments Download
M core/arch/interp.c View 6 chunks +12 lines, -8 lines 0 comments Download
M core/arch/opnd.h View 7 chunks +12 lines, -4 lines 0 comments Download
M core/arch/opnd_shared.c View 9 chunks +18 lines, -9 lines 0 comments Download
M core/arch/proc.h View 1 chunk +3 lines, -1 line 0 comments Download
M core/fragment.h View 1 chunk +2 lines, -4 lines 0 comments Download
M core/globals.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/lib/globals_shared.h View 4 chunks +10 lines, -3 lines 0 comments Download
M core/lib/instrument.c View 5 chunks +12 lines, -8 lines 0 comments Download
M core/lib/mcxtx.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/optionsx.h View 13 chunks +26 lines, -26 lines 0 comments Download
M core/os_shared.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/translate.c View 1 chunk +3 lines, -0 lines 0 comments Download
M core/unix/include/syscall.h View 1 chunk +1 line, -1 line 0 comments Download
M core/unix/include/syscall_linux_arm.h View 3 chunks +10 lines, -14 lines 0 comments Download
M core/unix/injector.c View 9 chunks +30 lines, -13 lines 0 comments Download
M core/unix/loader.c View 3 chunks +15 lines, -5 lines 0 comments Download
M core/unix/loader_linux.c View 7 chunks +18 lines, -17 lines 0 comments Download
M core/unix/module_elf.h View 1 chunk +36 lines, -24 lines 0 comments Download
M core/unix/module_elf.c View 3 chunks +15 lines, -8 lines 0 comments Download
M core/unix/native_elf.c View 1 chunk +2 lines, -2 lines 0 comments Download
M core/unix/os.c View 11 chunks +21 lines, -22 lines 0 comments Download
M core/unix/os_exports.h View 5 chunks +5 lines, -8 lines 0 comments Download
M core/unix/os_private.h View 1 chunk +4 lines, -0 lines 0 comments Download
M core/unix/os_public.h View 1 chunk +26 lines, -24 lines 0 comments Download
M core/unix/signal.c View 15 chunks +41 lines, -12 lines 0 comments Download
M core/unix/signal_linux.c View 1 chunk +1 line, -1 line 0 comments Download
M core/unix/signal_private.h View 2 chunks +17 lines, -2 lines 0 comments Download
M core/unix/tls.h View 3 chunks +6 lines, -10 lines 0 comments Download
M ext/drreg/drreg.c View 1 chunk +1 line, -1 line 0 comments Download
M ext/drutil/drutil.c View 4 chunks +4 lines, -4 lines 0 comments Download
M ext/drwrap/drwrap.h View 1 chunk +5 lines, -2 lines 0 comments Download
M ext/drwrap/drwrap.c View 7 chunks +7 lines, -7 lines 0 comments Download
M ext/drx/drx.h View 1 chunk +1 line, -1 line 0 comments Download
M ext/drx/drx.c View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3
Edmund.Grimley.Evans
10 years, 6 months ago (2016-03-21 11:46:07 UTC) #1
Edmund.Grimley.Evans
This is a new version of https://codereview.appspot.com/293720043 fixing i#1905. Tested on Red Hat Enterprise 6.6, ...
10 years, 6 months ago (2016-03-21 11:52:32 UTC) #2
Edmund.Grimley.Evans
10 years, 6 months ago (2016-03-21 11:53:04 UTC) #3
Committed as
https://github.com/DynamoRIO/dynamorio/commit/793392d3eb0d1c1e58788f07b1d3546...

Final commit log: 
---------------
i#1569 AArch64: Make AArch64 build.

It builds, but binaries are non-functional as many things are
not yet implemented.

Review-URL: https://codereview.appspot.com/288690043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b