Issue 288550043: TBR: Revert "i#1569 AArch64: Make AArch64 build."

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by bruening

Modified:
10 years, 7 months ago

Reviewers:
edmund.grimley-evans, Edmund.Grimley.Evans

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- Revert "i#1569 AArch64: Make AArch64 build." This reverts commit c2ecca24db224f9d5fe2a5193dacfa6af826b9d0 as it breaks the Linux x86 build. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+338 lines, -581 lines)			Patch
M	api/samples/CMakeLists.txt	View	2 chunks	+4 lines, -8 lines	0 comments	Download
M	core/arch/arch.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/arch/arch.c	View	11 chunks	+9 lines, -15 lines	0 comments	Download
M	core/arch/arch_exports.h	View	10 chunks	+9 lines, -50 lines	0 comments	Download
M	core/arch/asm_defines.asm	View	6 chunks	+43 lines, -69 lines	0 comments	Download
M	core/arch/decode.h	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	core/arch/emit_utils_shared.c	View	9 chunks	+5 lines, -30 lines	0 comments	Download
M	core/arch/instr.h	View	4 chunks	+1 line, -5 lines	0 comments	Download
M	core/arch/instr_create_shared.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	core/arch/instr_inline.h	View	3 chunks	+4 lines, -8 lines	0 comments	Download
M	core/arch/instr_shared.c	View	7 chunks	+5 lines, -15 lines	0 comments	Download
M	core/arch/interp.c	View	6 chunks	+8 lines, -12 lines	0 comments	Download
M	core/arch/opnd.h	View	7 chunks	+4 lines, -12 lines	0 comments	Download
M	core/arch/opnd_shared.c	View	9 chunks	+9 lines, -18 lines	0 comments	Download
M	core/arch/proc.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	core/fragment.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	core/globals.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	core/lib/globals_shared.h	View	4 chunks	+3 lines, -10 lines	0 comments	Download
M	core/lib/instrument.c	View	5 chunks	+8 lines, -12 lines	0 comments	Download
M	core/lib/mcxtx.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/optionsx.h	View	13 chunks	+26 lines, -26 lines	0 comments	Download
M	core/os_shared.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	core/translate.c	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	core/unix/include/syscall.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/unix/include/syscall_linux_arm.h	View	3 chunks	+14 lines, -10 lines	0 comments	Download
M	core/unix/injector.c	View	9 chunks	+13 lines, -30 lines	0 comments	Download
M	core/unix/loader.c	View	3 chunks	+5 lines, -15 lines	0 comments	Download
M	core/unix/loader_linux.c	View	7 chunks	+17 lines, -18 lines	0 comments	Download
M	core/unix/module_elf.h	View	1 chunk	+24 lines, -36 lines	0 comments	Download
M	core/unix/module_elf.c	View	3 chunks	+8 lines, -11 lines	0 comments	Download
M	core/unix/native_elf.c	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	core/unix/os.c	View	11 chunks	+22 lines, -21 lines	0 comments	Download
M	core/unix/os_exports.h	View	5 chunks	+8 lines, -5 lines	0 comments	Download
M	core/unix/os_private.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	core/unix/os_public.h	View	1 chunk	+24 lines, -26 lines	0 comments	Download
M	core/unix/signal.c	View	15 chunks	+12 lines, -41 lines	0 comments	Download
M	core/unix/signal_linux.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/unix/signal_private.h	View	2 chunks	+2 lines, -17 lines	0 comments	Download
M	core/unix/tls.h	View	3 chunks	+10 lines, -6 lines	0 comments	Download
M	ext/drreg/drreg.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ext/drutil/drutil.c	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	ext/drwrap/drwrap.h	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	ext/drwrap/drwrap.c	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	ext/drx/drx.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ext/drx/drx.c	View	5 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bruening

Committed as https://github.com/DynamoRIO/dynamorio/commit/b1c621fe54479045729545e3406c3823a4d51c15 Final commit log: --------------- Revert "i#1569 AArch64: Make AArch64 build." This reverts ...

10 years, 7 months ago (2016-03-11 19:43:49 UTC) #2

Edmund.Grimley.Evans

Why not just fix this as described in i#1905?

10 years, 7 months ago (2016-03-11 23:14:37 UTC) #3

bruening

10 years, 7 months ago (2016-03-12 12:50:36 UTC) #4

When there was no such fix submitted after the breakage the simplest route
to fix the build was to revert.

On Friday, March 11, 2016, <Edmund.Grimley.Evans@gmail.com
<javascript:_e(%7B%7D,'cvml','Edmund.Grimley.Evans@gmail.com');>> wrote:

> Why not just fix this as described in i#1905?
>
> https://codereview.appspot.com/288550043/
>

Expand All Messages | Collapse All Messages