Issue 288530043: DrM-i#1860: fuzz tests failure on Androi: preserve mcontext shape in insert_push_all_registers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 288530043: DrM-i#1860: fuzz tests failure on Androi: preserve mcontext shape in insert_push_all_registers

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 1 month ago by zhaoqin

Modified:
8 years, 1 month ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- DrM-i#1860: fuzz tests failure on Androi: preserve mcontext shape in insert_push_all_registers - preserve priv_mcontext_t shape in insert_push_all_registers - add test in drwrap-test with skipping flag ---------------

Patch Set 1 #

Total comments: 3

Patch Set 2 : Committed #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -6 lines)			Patch
M	core/arch/arm/mangle.c	View	1	3 chunks	+16 lines, -5 lines	0 comments	Download
M	suite/tests/client-interface/drwrap-test.appdll.c	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
M	suite/tests/client-interface/drwrap-test.dll.c	View		4 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bruening

commit message spells "Androi" wrong LGTM w/ comments https://codereview.appspot.com/288530043/diff/1/core/arch/arm/mangle.c File core/arch/arm/mangle.c (right): https://codereview.appspot.com/288530043/diff/1/core/arch/arm/mangle.c#newcode206 core/arch/arm/mangle.c:206: OPND_CREATE_INT8(offs_beyond_xmm))); ...

8 years, 1 month ago (2016-03-07 21:54:36 UTC) #2

zhaoqin

8 years, 1 month ago (2016-03-07 22:35:56 UTC) #3

Committed as
https://github.com/DynamoRIO/dynamorio/commit/612fe90d9bc5543e5d0df62ad5df288...

Final commit log: 
---------------
DrM-i#1860: fuzz tests failure on Android: preserve mcontext shape in
insert_push_all_registers

- preserve priv_mcontext_t shape in insert_push_all_registers
- add drwarp test with skipping flags in drwrap-test

Review-URL: https://codereview.appspot.com/288530043
---------------

Expand All Messages | Collapse All Messages