Issue 2880041: code review 2880041: Small addition to previous optimization of memequal as ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2880041: code review 2880041: Small addition to previous optimization of memequal as ...

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by gmiller

Modified:
13 years, 5 months ago

Reviewers:
r2

CC:
golang-dev, r, r2

Visibility:
Public.

Description

Small addition to previous optimization of memequal as discussed here: http://groups.google.com/group/golang-nuts/browse_thread/thread/f591ba36d83723c0/9aba02d344045f38

Patch Set 2 : code review 2880041: Small addition to previous optimization of memequal as ... #

Total comments: 1

Patch Set 3 : code review 2880041: Small addition to previous optimization of memequal as ... #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/pkg/runtime/runtime.c	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

gmiller

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 5 months ago (2010-11-03 20:32:15 UTC) #1

http://codereview.appspot.com/2880041/diff/2001/src/pkg/runtime/runtime.c File src/pkg/runtime/runtime.c (right): http://codereview.appspot.com/2880041/diff/2001/src/pkg/runtime/runtime.c#newcode321 src/pkg/runtime/runtime.c:321: if(a == b) this will almost always fail, which ...

13 years, 5 months ago (2010-11-04 18:54:04 UTC) #2

gmiller

> this will almost always fail, which means the branch prediction will skip it > ...

13 years, 5 months ago (2010-11-04 19:14:48 UTC) #3

you need to sync and re-upload before i can submit the patch -rob

13 years, 5 months ago (2010-11-04 19:21:06 UTC) #5

gmiller

Hello golang-dev@googlegroups.com, r, r2 (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 5 months ago (2010-11-04 20:44:22 UTC) #6

13 years, 5 months ago (2010-11-04 20:45:22 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=403b3daec0f2 ***

Small addition to previous optimization of memequal as discussed here:
http://groups.google.com/group/golang-nuts/browse_thread/thread/f591ba36d8372...

R=golang-dev, r, r2
CC=golang-dev
http://codereview.appspot.com/2880041

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages