Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7913)

Issue 287970043: Restrict transforms to GSA, fully trusted clients (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by myk
Modified:
1 week, 4 days ago
Reviewers:
baby546833, pjo
CC:
connector-cr_google.com
Visibility:
Public.

Description

Restrict transforms to GSA, fully trusted clients

Patch Set 1 #

Total comments: 12

Patch Set 2 : Addressed PJ's comments from Patch Set 1 #

Total comments: 16
Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -9 lines) Patch
M src/com/google/enterprise/adaptor/DocumentHandler.java View 1 6 chunks +34 lines, -9 lines 12 comments Download
M test/com/google/enterprise/adaptor/DocumentHandlerTest.java View 1 7 chunks +136 lines, -0 lines 4 comments Download

Messages

Total messages: 7
myk
6 years, 10 months ago (2016-01-28 22:22:12 UTC) #1
pjo
Thank you. https://codereview.appspot.com/287970043/diff/1/src/com/google/enterprise/adaptor/DocumentHandler.java File src/com/google/enterprise/adaptor/DocumentHandler.java (right): https://codereview.appspot.com/287970043/diff/1/src/com/google/enterprise/adaptor/DocumentHandler.java#newcode772 src/com/google/enterprise/adaptor/DocumentHandler.java:772: .createPipeline(os, originalContentType, metadata); It kind of looks ...
6 years, 10 months ago (2016-01-29 06:03:51 UTC) #2
myk
Made all recommended changes to DocumentHandler.java; made change that was possible (and explained why the ...
6 years, 10 months ago (2016-01-29 18:34:50 UTC) #3
myk
PJ, Please take another look at this today. Thanks!
6 years, 10 months ago (2016-02-01 15:14:56 UTC) #4
pjo
LGTM. Thank you. I think these comments are mostly for a follow up CL which ...
6 years, 10 months ago (2016-02-02 02:22:07 UTC) #5
myk
Answering your questions here, but not making any code changes since Patch Set 2. All ...
6 years, 10 months ago (2016-02-02 19:05:54 UTC) #6
baby546833
4 years, 10 months ago (2018-01-24 09:17:33 UTC) #7
Message was sent while issue was closed.
賤人死妓女
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b