Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6366)

Issue 287810043: i#1847 fix test fuzz_buffer failure with option -fuzz_replace_buffer

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by zhaoqin
Modified:
8 years, 3 months ago
Reviewers:
bruening
CC:
drmemory-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1847 fix test fuzz_buffer failure with option -fuzz_replace_buffer - replace mutation_start field in fuzz_state_t with MUTATION_START macro - update load_fuzz_input() to only increase the buffer size for -fuzz_replace_buffer - add fuzz_buffer.replace_buffer test - shrink corpus.2.dat to test how buffe size changes on smaller corpus files Fixes #1847 ---------------

Patch Set 1 #

Patch Set 2 : update commit msg #

Patch Set 3 : update commit msg #

Total comments: 4

Patch Set 4 : final #

Patch Set 5 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -14 lines) Patch
M drmemory/fuzzer.c View 1 2 3 4 9 chunks +29 lines, -14 lines 0 comments Download
M tests/fuzz/CMakeLists.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/fuzz/corpus/corpus.2.dat View Binary file 0 comments Download

Messages

Total messages: 9
zhaoqin
8 years, 3 months ago (2016-01-18 05:52:43 UTC) #1
bruening
On 2016/01/18 05:52:43, zhaoqin wrote: > - shrink corpus.2.dat to test how buffe size changes ...
8 years, 3 months ago (2016-01-18 22:08:56 UTC) #2
zhaoqin
Commit log for latest patchset: --------------- i#1847 fix test fuzz_buffer failure with option -fuzz_replace_buffer - ...
8 years, 3 months ago (2016-01-18 23:29:22 UTC) #3
bruening
On 2016/01/18 23:29:22, zhaoqin wrote: > - shrink corpus.2.dat to test how buffle size changes ...
8 years, 3 months ago (2016-01-19 18:11:56 UTC) #4
zhaoqin
Commit log for latest patchset: --------------- i#1847 fix test fuzz_buffer failure with option -fuzz_replace_buffer - ...
8 years, 3 months ago (2016-01-19 18:51:29 UTC) #5
bruening
LGTM w/ comments https://codereview.appspot.com/287810043/diff/40001/drmemory/fuzzer.c File drmemory/fuzzer.c (right): https://codereview.appspot.com/287810043/diff/40001/drmemory/fuzzer.c#newcode661 drmemory/fuzzer.c:661: /* We only reallocate larger buffer ...
8 years, 3 months ago (2016-01-19 21:21:03 UTC) #6
bruening
On 2016/01/19 18:51:29, zhaoqin wrote: > Commit log for latest patchset: > --------------- > i#1847 ...
8 years, 3 months ago (2016-01-19 21:21:25 UTC) #7
zhaoqin
Commit log for latest patchset: --------------- i#1847: fix test fuzz_buffer failure with option -fuzz_replace_buffer - ...
8 years, 3 months ago (2016-01-20 03:15:42 UTC) #8
zhaoqin
8 years, 3 months ago (2016-01-20 05:21:04 UTC) #9
Committed as
https://github.com/DynamoRIO/drmemory/commit/ba3914cb7b08552b96d722ccc2798d4c...

Final commit log: 
---------------
i#1847: fix test fuzz_buffer failure with option -fuzz_replace_buffer

- replace mutation_start field in fuzz_state_t with MUTATION_START macro
- update load_fuzz_input() to only increase the buffer size for
-fuzz_replace_buffer
- add fuzz_buffer.replace_buffer test
- shrink corpus.2.dat to test how buffer size changes on smaller corpus files

Fixes #1847

Review-URL: https://codereview.appspot.com/287810043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b