Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(91)

Issue 28770043: Add a download cache for test dependencies

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by gary.poster
Modified:
5 years, 10 months ago
Reviewers:
mp+195700, frankban
Visibility:
Public.

Description

Add a download cache for test dependencies To QA, remove the .venv in your tests dir and try running make. It is a lot faster and more reliable for me. Testing make clean would be good too. https://code.launchpad.net/~gary/charms/precise/juju-gui/download-cache/+merge/195700 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add a download cache for test dependencies #

Patch Set 3 : Add a download cache for test dependencies #

Patch Set 4 : Add a download cache for test dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -6 lines) Patch
M .bzrignore View 1 chunk +1 line, -0 lines 0 comments Download
M HACKING.md View 1 chunk +21 lines, -0 lines 0 comments Download
M Makefile View 1 chunk +1 line, -0 lines 0 comments Download
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M test-requirements.pip View 1 chunk +19 lines, -0 lines 0 comments Download
M tests/00-setup View 1 2 chunks +8 lines, -1 line 0 comments Download
M tests/deploy.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/test_deploy.py View 1 2 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5
gary.poster
Please take a look.
5 years, 10 months ago (2013-11-19 02:55:52 UTC) #1
frankban
A very nice improvement Gary, thank you! Running "make" successfully checked out the download cache ...
5 years, 10 months ago (2013-11-19 08:59:56 UTC) #2
frankban
FWIW, this diff here seems to work: http://pastebin.ubuntu.com/6442036/ Note the leading slash in '/tests': that's ...
5 years, 10 months ago (2013-11-19 10:19:06 UTC) #3
gary.poster
*** Submitted: Add a download cache for test dependencies To QA, remove the .venv in ...
5 years, 10 months ago (2013-11-19 15:23:00 UTC) #4
gary.poster
5 years, 10 months ago (2013-11-19 15:25:55 UTC) #5
Thank you for the great review and suggestions, Francesco.  I implemented both,
choosing to use the /tests approach you mentioned for the first one.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b