Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 287370043: i#1569 AArch64: Add files in core/arch/aarch64/ with minimal stubs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by Edmund.Grimley.Evans
Modified:
10 years, 3 months ago
Reviewers:
zhaoqin, bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1569 AArch64: Add files in core/arch/aarch64/ with minimal stubs. ---------------

Patch Set 1 #

Total comments: 1

Patch Set 2 : With FIXME #

Total comments: 6

Patch Set 3 : With NYI #

Patch Set 4 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1862 lines, -155 lines) Patch
A core/arch/aarch64/aarch64.asm View 1 2 3 1 chunk +244 lines, -0 lines 0 comments Download
A + core/arch/aarch64/aarch64_shared.asm View 1 2 3 1 chunk +14 lines, -32 lines 0 comments Download
A + core/arch/aarch64/clean_call_opt.c View 1 2 1 chunk +17 lines, -22 lines 0 comments Download
A core/arch/aarch64/decode.c View 1 1 chunk +239 lines, -0 lines 0 comments Download
A + core/arch/aarch64/decode_private.h View 3 chunks +10 lines, -10 lines 0 comments Download
A + core/arch/aarch64/disassemble.c View 1 2 1 chunk +44 lines, -19 lines 0 comments Download
A core/arch/aarch64/emit_utils.c View 1 1 chunk +304 lines, -0 lines 0 comments Download
A + core/arch/aarch64/encode.c View 1 2 1 chunk +39 lines, -20 lines 0 comments Download
A core/arch/aarch64/instr.c View 1 1 chunk +299 lines, -0 lines 0 comments Download
M core/arch/aarch64/instr_create.h View 1 2 3 1 chunk +264 lines, -1 line 0 comments Download
A core/arch/aarch64/mangle.c View 1 1 chunk +219 lines, -0 lines 0 comments Download
M core/arch/aarch64/opcode.h View 1 chunk +92 lines, -1 line 0 comments Download
A + core/arch/aarch64/opnd.c View 1 2 1 chunk +24 lines, -23 lines 0 comments Download
A + core/arch/aarch64/optimize.c View 1 3 chunks +10 lines, -9 lines 0 comments Download
A + core/arch/aarch64/proc.c View 1 2 1 chunk +43 lines, -18 lines 0 comments Download

Messages

Total messages: 8
Edmund.Grimley.Evans
10 years, 4 months ago (2016-03-03 14:00:12 UTC) #1
bruening
Took a quick look -- in general all unfinished code should have FIXME i# comments. ...
10 years, 4 months ago (2016-03-03 14:26:54 UTC) #2
Edmund.Grimley.Evans
On 2016/03/03 14:26:54, bruening wrote: > Took a quick look -- in general all unfinished ...
10 years, 4 months ago (2016-03-03 14:37:26 UTC) #3
bruening
On 2016/03/03 14:37:26, Edmund.Grimley.Evans wrote: > I'm assuming that ASSERT_NOT_IMPLEMENTED(false) does not require a comment. ...
10 years, 4 months ago (2016-03-03 14:43:36 UTC) #4
Edmund.Grimley.Evans
Commit log for latest patchset: --------------- i#1569 AArch64: Add files in core/arch/aarch64/. This continues filling ...
10 years, 4 months ago (2016-03-03 15:22:24 UTC) #5
Edmund.Grimley.Evans
Commit log for latest patchset: --------------- i#1569 AArch64: Add files in core/arch/aarch64/. This continues filling ...
10 years, 4 months ago (2016-03-03 17:13:28 UTC) #6
zhaoqin
LGTM with nits https://codereview.appspot.com/287370043/diff/20001/core/arch/aarch64/aarch64.asm File core/arch/aarch64/aarch64.asm (right): https://codereview.appspot.com/287370043/diff/20001/core/arch/aarch64/aarch64.asm#newcode44 core/arch/aarch64/aarch64.asm:44: check it is not 32-bit https://codereview.appspot.com/287370043/diff/20001/core/arch/aarch64/aarch64.asm#newcode55 ...
10 years, 4 months ago (2016-03-03 20:07:08 UTC) #7
Edmund.Grimley.Evans
10 years, 4 months ago (2016-03-04 09:44:51 UTC) #8
Committed as
https://github.com/DynamoRIO/dynamorio/commit/cc19b1af0c7c0374705d63cece2ee0e...

Final commit log: 
---------------
i#1569 AArch64: Add files in core/arch/aarch64/.

This continues filling in the code needed for AArch64 but with empty
work-in-progress function bodies.

Review-URL: https://codereview.appspot.com/287370043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b