i#1569 AArch64: Add files in core/arch/aarch64/ with minimal stubs.

Commit log for first patchset:
---------------
i#1569 AArch64: Add files in core/arch/aarch64/ with minimal stubs.
---------------

[bruening, 2016-03-03 14:26:54]

Took a quick look -- in general all unfinished code should have FIXME i#
comments.

https://codereview.appspot.com/287370043/diff/1/core/arch/aarch64/aarch64.asm
File core/arch/aarch64/aarch64.asm (right):

https://codereview.appspot.com/287370043/diff/1/core/arch/aarch64/aarch64.asm...
core/arch/aarch64/aarch64.asm:48: bl       GLOBAL_REF(unexpected_return)
These all need FIXME i# comments (the idea is that someone looking at this code
right now should be able to easily tell if this is what was intended or if this
is work in progress).

[Edmund.Grimley.Evans, 2016-03-03 14:37:26]

On 2016/03/03 14:26:54, bruening wrote:
> Took a quick look -- in general all unfinished code should have FIXME i#
> comments.
> 
> https://codereview.appspot.com/287370043/diff/1/core/arch/aarch64/aarch64.asm
> File core/arch/aarch64/aarch64.asm (right):
> 
>
https://codereview.appspot.com/287370043/diff/1/core/arch/aarch64/aarch64.asm...
> core/arch/aarch64/aarch64.asm:48: bl       GLOBAL_REF(unexpected_return)
> These all need FIXME i# comments (the idea is that someone looking at this
code
> right now should be able to easily tell if this is what was intended or if
this
> is work in progress).

Thanks. Done thus:

perl -i -pe 's!$! /* FIXME i#1569 */! if /unexpected_return/;'
core/arch/aarch64/*

I'm assuming that ASSERT_NOT_IMPLEMENTED(false) does not require a comment.

[bruening, 2016-03-03 14:43:36]

On 2016/03/03 14:37:26, Edmund.Grimley.Evans wrote:
> I'm assuming that ASSERT_NOT_IMPLEMENTED(false) does not require a comment.

Yes, we prefer a comment for these too, so that there is an issue number and an
indication that this is not something that will never be supported on that
platform but instead something that is in progress.

[Edmund.Grimley.Evans, 2016-03-03 15:22:24]

Commit log for latest patchset:
---------------
i#1569 AArch64: Add files in core/arch/aarch64/.

This continues filling in the code needed for AArch64 but with empty
work-in-progress function bodies.

Review-URL: https://codereview.appspot.com/287370043
---------------

[Edmund.Grimley.Evans, 2016-03-03 17:13:28]

Commit log for latest patchset:
---------------
i#1569 AArch64: Add files in core/arch/aarch64/.

This continues filling in the code needed for AArch64 but with empty
work-in-progress function bodies.

Review-URL: https://codereview.appspot.com/287370043
---------------

[zhaoqin, 2016-03-03 20:07:08]

LGTM with nits

https://codereview.appspot.com/287370043/diff/20001/core/arch/aarch64/aarch64...
File core/arch/aarch64/aarch64.asm (right):

https://codereview.appspot.com/287370043/diff/20001/core/arch/aarch64/aarch64...
core/arch/aarch64/aarch64.asm:44: 
check it is not 32-bit

https://codereview.appspot.com/287370043/diff/20001/core/arch/aarch64/aarch64...
core/arch/aarch64/aarch64.asm:55: END_FUNC(xfer_to_new_libdr)
this should be only used for dynamic loading (i.e., !UNIT_TEST & !STATIC_LIB),
so I would include this function in the # if above.

https://codereview.appspot.com/287370043/diff/20001/core/arch/aarch64/aarch64...
core/arch/aarch64/aarch64.asm:57: DECLARE_FUNC(call_switch_stack)
For each of such asm function, we want to add comment about the function
signature, but I think it is ok to add it later with the real implementation.

https://codereview.appspot.com/287370043/diff/20001/core/arch/aarch64/aarch64...
File core/arch/aarch64/aarch64_shared.asm (right):

https://codereview.appspot.com/287370043/diff/20001/core/arch/aarch64/aarch64...
core/arch/aarch64/aarch64_shared.asm:32: 
do you think if we should have a small summary for what the file for as we did
for arm_shared.asm

https://codereview.appspot.com/287370043/diff/20001/core/arch/aarch64/instr_c...
File core/arch/aarch64/instr_create.h (right):

https://codereview.appspot.com/287370043/diff/20001/core/arch/aarch64/instr_c...
core/arch/aarch64/instr_create.h:259: instr_create_0dst_1src((dc), OP_xx,
OPND_CREATE_INT32(enc))
what is this OP_xx?

update: maybe add comment about it is place holder.

https://codereview.appspot.com/287370043/diff/20001/core/arch/aarch64/optimize.c
File core/arch/aarch64/optimize.c (right):

https://codereview.appspot.com/287370043/diff/20001/core/arch/aarch64/optimiz...
core/arch/aarch64/optimize.c:33: #include "../globals.h"
nit, comment about why we include the file.

[Edmund.Grimley.Evans, 2016-03-04 09:44:51]

Committed as
https://github.com/DynamoRIO/dynamorio/commit/cc19b1af0c7c0374705d63cece2ee0e...

Final commit log: 
---------------
i#1569 AArch64: Add files in core/arch/aarch64/.

This continues filling in the code needed for AArch64 but with empty
work-in-progress function bodies.

Review-URL: https://codereview.appspot.com/287370043
---------------