Issue 287160043: Whitelist iterator.next unconditionally

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 287160043: Whitelist iterator.next unconditionally (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 2 months ago by MarkM

Modified:
8 years, 2 months ago

Reviewers:
kpreid_google

CC:
google-caja-discuss_googlegroups.com

Visibility:
Public.

More Reviews

Description

Technically, for SES-on-ES5, we should not need to whitelist 'next'. However, browsers are accidentally relying on it https://bugs.chromium.org/p/v8/issues/detail?id=4769# https://bugs.webkit.org/show_bug.cgi?id=154475 and we will be whitelisting it as we transition to ES6 anyway, so we unconditionally whitelist it now.

Patch Set 1 #

Patch Set 2 : Whitelist iterator.next unconditionally #

Patch Set 3 : Whitelist iterator.next unconditionally #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -99 lines)			Patch
M	src/com/google/caja/ses/repairES5.js	View	1 2	4 chunks	+2 lines, -60 lines	0 comments	Download
M	src/com/google/caja/ses/startSES.js	View	1	4 chunks	+1 line, -30 lines	0 comments	Download
M	src/com/google/caja/ses/whitelist.js	View		3 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

MarkM

Technically, for SES-on-ES5, we should not need to whitelist 'next'. However, browsers are accidentally relying ...

8 years, 2 months ago (2016-02-22 22:32:57 UTC) #2

MarkM

New snapshot, mostly getting rid of code that's no longer needed.

8 years, 2 months ago (2016-02-22 22:34:00 UTC) #3

MarkM

8 years, 2 months ago (2016-02-23 02:47:46 UTC) #5

Technically, for SES-on-ES5, we should not need to whitelist
'next'. However, browsers are accidentally relying on it
https://bugs.chromium.org/p/v8/issues/detail?id=4769#
https://bugs.webkit.org/show_bug.cgi?id=154475 and we will be
whitelisting it as we transition to ES6 anyway, so we unconditionally
whitelist it now.

We also get rid of _optForeignForIn and
CROSS_FRAME_FOR_IN_NEEDS_INHERITED_NEXT since these are no longer
needed.
Merging two unrelated changes

Expand All Messages | Collapse All Messages